- Notifications
You must be signed in to change notification settings - Fork516
Build tests prior to executing them#4523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
epistax wants to merge3 commits intomicrosoft:mainChoose a base branch fromepistax:building-tests
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Author
epistax commentedJul 22, 2025
@microsoft-github-policy-service agree company="Markem-Imaje" |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This change addresses item#4515
This changes the build-before-test behavior
The following changes are proposed:
The purpose of this change
Other Notes/Information
I have never contributed to this project before and I ran into difficulties running the tests. I was not able to find any testss related to the change and I'd be willing to expand the test base with a little bit of instruction. I was not able to find a proper venue for getting started with the testing. There appears to be some required machine setup prior to running the tests. Thank you for any assistance!
This change opens up the possibility for very long command lines when invoking CMake. I am not aware if munging is taken care of automatically or if I need to introduce something myself.