Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fire onDidChangeHeight after code block editor render completes. Fix #265031#274691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@tamuratak
Copy link
Contributor

Fire onDidChangeHeight after code block editor render completes.Fix#265031

Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR modifies the code block rendering logic to fire a height change event after the asynchronousrender() operation completes, ensuring the UI properly updates when rendering finishes.

Key Changes

  • ModifiedrenderCodeBlock method to chain a.then() callback on theeditorInfo.render() promise to fire_onDidChangeHeight event after rendering completes

@bpasero
Copy link
Member

I wonder if this is the fix for#274428@mjbvz ?

@mjbvzmjbvz added this to theNovember 2025 milestoneNov 4, 2025
@justschenjustschen merged commit04dfadd intomicrosoft:mainNov 11, 2025
32 of 34 checks passed
@tamurataktamuratak deleted the fix_codeblock_rendering_d branchNovember 21, 2025 23:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@bpaserobpaserobpasero approved these changes

@mjbvzmjbvzmjbvz approved these changes

Assignees

@mjbvzmjbvz

@justschenjustschen

Labels

None yet

Projects

None yet

Milestone

November 2025

Development

Successfully merging this pull request may close these issues.

The user message is trimmed in the Chat panel

4 participants

@tamuratak@bpasero@mjbvz@justschen
[8]ページ先頭
©2009-2025 Movatter.jp