- Notifications
You must be signed in to change notification settings - Fork33.9k
feat: usev
-mode regexps for search and find#254813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
lionel-rowe wants to merge5 commits intomicrosoft:mainChoose a base branch fromlionel-rowe:search-regex-v-mode
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+26 −13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
v
-mode regexps for search and findd39f34c
to58e3412
CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closes#254625
This feature switches from
u
-mode (unicode
) to the more powerfulv
-mode (unicodeSets
) regular expressions for regexp search/find.To test manually: regexp search/find for
[[a-z]--[f-v]]
within a document containing the text "hello, world!". The letterse
,w
, andd
will be matched:RegExpOptions
'sunicode
is now a ternarytrue = u, "unicodeSets" = v, false/nullish = none
. Hope that's acceptable as an interface, I could alternatively addunicodeSets
as another boolean option (suboptimal asu
andv
are mutually exclusive) or change it to a union of string values (but then more changes to calling code would be needed).This PR also aliases the existing
escapeRegExpCharacters
to the newRegExp.escape
built-in API (available in Electron 37). This is necessary to ensure the escaping logic works correctly for all possible inputs in all contexts inv
-mode as well as other modes: