Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Do not check for navigator to detect web environment in built-in extensions#251688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bpasero merged 1 commit intomicrosoft:mainfromjeanp413:jp/direct-spider
Jun 18, 2025

Conversation

jeanp413
Copy link
Contributor

@jeanp413jeanp413 commentedJun 17, 2025•
edited
Loading

Do not check for navigator to detect web environment in built-in extensions
Use recommendedcheck from release notes

Fixes#251541

@jeanp413
Copy link
ContributorAuthor

cc@mjbvz

@jeanp413jeanp413 changed the titleDo not check for navigator to detect web environment in extensionsDo not check for navigator to detect web environment in built-in extensionsJun 17, 2025
@dbaeumerdbaeumer assignedmjbvz and unassigneddbaeumer andmjbvzJun 17, 2025
@dbaeumerdbaeumer assignedmjbvz and unassigneddbaeumer andmjbvzJun 17, 2025
@bpasero
Copy link
Member

@deepak1556 fyi, I wonder if we did not fully adopt this yet in our code?

@deepak1556
Copy link
Collaborator

Yeah we haven't adopted the changes in all of our extensions but our polyfill#250619 is meant to avoid any issues for such conditions.

@jeanp413 I rancode-insiders serve-web and connected a debugger to remote extension host and see the following, can you share the steps that led to navigator being defined which caused issue for the relevant extension

Screenshot 2025-06-18 at 2 37 31
bpasero reacted with thumbs up emoji

@jeanp413
Copy link
ContributorAuthor

jeanp413 commentedJun 18, 2025•
edited
Loading

@deepak1556 The issue is the way it's checked in the typescript extension'navigator' in globalThis returnstrue becausenavigator property is defined but has valueundefined

@deepak1556
Copy link
Collaborator

Ah thats a good catch, we could probably proxy thehas method to cover thein operator. However, this PR should be merged as a potential fix.

@vs-code-engineeringvs-code-engineeringbot added this to theJune 2025 milestoneJun 18, 2025
@bpaserobpaseroenabled auto-merge (squash)June 18, 2025 04:37
@bpaserobpasero merged commit0140ab3 intomicrosoft:mainJun 18, 2025
7 checks passed
deepak1556 pushed a commit that referenced this pull requestJun 18, 2025
…nsions (#251688)Do not check for navigator to detect web environment
deepak1556 pushed a commit that referenced this pull requestJun 18, 2025
…nsions (#251688)Do not check for navigator to detect web environment
deepak1556 added a commit that referenced this pull requestJun 18, 2025
Do not check for navigator to detect web environment in built-in extensions (#251688)Do not check for navigator to detect web environmentCo-authored-by: Jean Pierre <jeanp413@hotmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bpaserobpaserobpasero approved these changes

@deepak1556deepak1556deepak1556 approved these changes

Assignees

@mjbvzmjbvz

Labels
None yet
Projects
None yet
Milestone
June 2025
Development

Successfully merging this pull request may close these issues.

VS Code Update Causes TypeScript Server Crashes with SIGTERM in GitHub Codespaces (VS Code 1.101.0)
5 participants
@jeanp413@bpasero@deepak1556@dbaeumer@mjbvz
[8]ページ先頭
©2009-2025 Movatter.jp