Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix markdown preview scroll crawls at EOF (fix #249278)#251228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mjbvz merged 1 commit intomicrosoft:mainfromheoh:fix-249278
Jun 11, 2025

Conversation

heoh
Copy link
Contributor

Fix scrolling of markdown preview at EOF. This PRfixes#249278.

  • Remove logic that causes scroll errors.

Cause

  • At EOF, scroll synchronization is performed every time a character is typed.
  • At EOF, the calculatedscrollTo is very small, less than 1, but the postprocessing scrolls more than necessary.
    This causes errors again, and to reduce this error,scrollTo is set in the opposite direction again.
  • This eventually repeats with every typing, occurs a "crawls" issue.

Resolve

  1. First, I removed the logic that causes errors.

  2. I checked the history at the time by finding the PR and Issue where the code was written. (457acf8,Fix scrolling of markdown preview. Close #65504 #111094)
    The code was originally written intentionally to fix an old another scrolling issue.
    However, I tested it myself, and the issue that was there before is no longer occurring.

Test

I have tested this PR with the document referenced by previous contributorshttps://github.com/jlelong/LaTeX-Workshop-wiki/blob/master/Hover.md.

Before

before

After

after

Test previous issue

test-old-issue

Copy link
Collaborator

@mjbvzmjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

heoh reacted with thumbs up emoji
@mjbvzmjbvzenabled auto-mergeJune 11, 2025 22:30
@mjbvzmjbvz added this to theJune 2025 milestoneJun 11, 2025
@mjbvzmjbvz merged commitb104f81 intomicrosoft:mainJun 11, 2025
7 checks passed
@stephenatwork
Copy link
Member

Lovely writeup. Thanks@heoh!

heoh reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@rzhao271rzhao271rzhao271 approved these changes

@mjbvzmjbvzmjbvz approved these changes

Assignees

@mjbvzmjbvz

Labels
None yet
Projects
None yet
Milestone
June 2025
Development

Successfully merging this pull request may close these issues.

Markdown preview scroll "crawls" at EOF
4 participants
@heoh@stephenatwork@rzhao271@mjbvz

[8]ページ先頭

©2009-2025 Movatter.jp