- Notifications
You must be signed in to change notification settings - Fork33.8k
Fix markdown preview scroll crawls at EOF (fix #249278)#251228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
mjbvz approved these changesJun 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
rzhao271 approved these changesJun 11, 2025
b104f81
intomicrosoft:main 7 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Lovely writeup. Thanks@heoh! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix scrolling of markdown preview at EOF. This PRfixes#249278.
Cause
scrollTo
is very small, less than 1, but the postprocessing scrolls more than necessary.This causes errors again, and to reduce this error,
scrollTo
is set in the opposite direction again.Resolve
First, I removed the logic that causes errors.
I checked the history at the time by finding the PR and Issue where the code was written. (457acf8,Fix scrolling of markdown preview. Close #65504 #111094)
The code was originally written intentionally to fix an old another scrolling issue.
However, I tested it myself, and the issue that was there before is no longer occurring.
Test
I have tested this PR with the document referenced by previous contributorshttps://github.com/jlelong/LaTeX-Workshop-wiki/blob/master/Hover.md.
Before
After
Test previous issue