NotificationsYou must be signed in to change notification settings
Fork33.8k
Star175k

Update copyFiles.ts#250773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mjbvz merged 4 commits intomicrosoft:mainfromghLcd9dG:main

Jun 23, 2025

Merged

Update copyFiles.ts#250773

mjbvz merged 4 commits intomicrosoft:mainfromghLcd9dG:main

Jun 23, 2025

Conversation

Copy link

Contributor

ghLcd9dG commentedJun 5, 2025

add isoTime to markdown extension copy file destination options.
I guess many people need that (e.g., me)

Update copyFiles.ts

e741ef4

vs-code-engineeringbot added the triage-needed label

Jun 5, 2025

vs-code-engineeringbot assignedaeschli

Jun 5, 2025

aeschli assignedmjbvz and unassignedaeschli

Jun 6, 2025

DhruvTheDev1 reviewed

Jun 6, 2025

View reviewed changes

Copy link

DhruvTheDev1 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good overall — adding isoTime is a nice touch for more readable timestamps when copying files.

Merge branch 'main' into main

47871a8

mjbvz requested changes

Jun 16, 2025

View reviewed changes

Copy link

Collaborator

mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Doesn't seem to include any code changes

DhruvTheDev1 reviewed

Jun 16, 2025

View reviewed changes

Copy link

DhruvTheDev1 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

['isoTime', new Date().toISOString()]
Adds a variable 'isoTime' in the resolveCopyDestinationSetting function which lets users include ${isoTime} in the destination path template.

mjbvz requested changes

Jun 16, 2025

View reviewed changes

Copy link

Collaborator

mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks. This also needs to be documented in for the settings. Check themarkdown-language-features settings json

DhruvTheDev1 mentioned this pull request

Jun 17, 2025

Update package.nls.json#251706

Closed

Copy link

DhruvTheDev1 commentedJun 17, 2025

I opened a follow up PR to document the added isotime variable in the setting description
Update package.nls.json#251706

Copy link

Collaborator

mjbvz commentedJun 17, 2025

Please put all the related changes into a single PR. That helps review and tracking work on the feature

ghLcd9dG added2 commits

June 20, 2025 11:59

Merge branch 'main' into main

8a599c3

Update package.nls.json

39d6463

Copy link

ContributorAuthor

ghLcd9dG commentedJun 20, 2025

@ghLcd9dG please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:
(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

@microsoft-github-policy-service agree