NotificationsYou must be signed in to change notification settings
Fork33.8k
Star175k

Fix #250737, Match count result overflow in Notebook findWidget#250738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Yoyokrazy merged 1 commit intomicrosoft:mainfromyiliang114:excellent-chameleon

Jun 10, 2025

Merged

Fix #250737, Match count result overflow in Notebook findWidget#250738

Yoyokrazy merged 1 commit intomicrosoft:mainfromyiliang114:excellent-chameleon

Jun 10, 2025

Conversation

Copy link

Contributor

yiliang114 commentedJun 5, 2025

Before fix:

After fix:

I saw that theminWidth here was modified in this#147398 . Now after revising back to theminWidth, it seems that there won't be any problems now either.

Fixmicrosoft#250737, Match count result overflow in Notebook findWidget

07dd417

vs-code-engineeringbot added the triage-needed label

Jun 5, 2025

vs-code-engineeringbot assignedulugbekna

Jun 5, 2025

ulugbekna assignedosortega and unassignedulugbekna

Jun 5, 2025

Copy link

ContributorAuthor

yiliang114 commentedJun 8, 2025

hi,@osortega Can you help me review the code?

osortega assignedYoyokrazy and unassignedosortega

Jun 9, 2025

osortega removed the triage-needed label

Jun 9, 2025

Yoyokrazy approved these changes

Jun 10, 2025

View reviewed changes

Copy link

Collaborator

Yoyokrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for the community PR! This looks good to me 👍

With the additional CSS that was brought in via the earlier PR you mentioned, and (somewhat) recent changes to the starting width of the notebook find widget, this seems like a good fix.