NotificationsYou must be signed in to change notification settings
Fork37k
Star180k

Also replace keys in object within variable substitution#245989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

connor4312 merged 2 commits intomicrosoft:mainfromzobo:fix-variable-key-object-substitution

Apr 8, 2025

Merged

Also replace keys in object within variable substitution#245989

connor4312 merged 2 commits intomicrosoft:mainfromzobo:fix-variable-key-object-substitution

Apr 8, 2025

Conversation

Copy link

Contributor

zobo commentedApr 8, 2025

Proposed fix for#245798

Also replace keys in object within variable substitution

10cbccc

vs-code-engineeringbot assignedroblourens

Apr 8, 2025

roblourens assignedconnor4312 and unassignedroblourens

Apr 8, 2025

connor4312 previously approved these changes

Apr 8, 2025

View reviewed changes

Copy link

Member

connor4312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR!

Copy link

Member

connor4312 commentedApr 8, 2025

Looks like the build failed though!

vs-code-engineeringbot added this to theApril 2025 milestone

Apr 8, 2025

Copy link

ContributorAuthor

zobo commentedApr 8, 2025

Will look into it shortly.

Copy link

ContributorAuthor

zobo commentedApr 8, 2025

It says "1 more collaborator approval(s) required".

lramos15 previously approved these changes

Apr 8, 2025

View reviewed changes

Copy link

Member

connor4312 commentedApr 8, 2025

the failing check is Code - OSS

[eslint                   ] [13:41:36] /mnt/vss/_work/1/s/src/vs/workbench/services/configurationResolver/common/configurationResolverExpression.ts: line 227, col 40, Warning - Missing semicolon. (@stylistic/ts/semi)[eslint                   ] /mnt/vss/_work/1/s/src/vs/workbench/services/configurationResolver/common/configurationResolverExpression.ts: line 229, col 33, Warning - Missing semicolon. (@stylistic/ts/semi)[eslint                   ] /mnt/vss/_work/1/s/src/vs/workbench/services/configurationResolver/common/configurationResolverExpression.ts: line 230, col 30, Warning - Missing semicolon. (@stylistic/ts/semi)

and a test failure on Linux/macOS

1) Configuration Resolver Service       substitution in object key:            + expected - actual       {         "mappings": {      -    "/VSCode/workspaceLocation/test1": "/VSCode/workspaceLocation/test2"      +    "file:///VSCode/workspaceLocation/test1": "file:///VSCode/workspaceLocation/test2"           "pos1": "value1"           "pos3": "value3"         }