NotificationsYou must be signed in to change notification settings
Fork37k
Star180k

git: make Letter/Text/Color semantically consistency#245889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

lszomoru merged 2 commits intomicrosoft:mainfromCecil0o0:combine_conditions

Apr 15, 2025

Merged

git: make Letter/Text/Color semantically consistency#245889

lszomoru merged 2 commits intomicrosoft:mainfromCecil0o0:combine_conditions

Apr 15, 2025

Conversation

Copy link

Contributor

Cecil0o0 commentedApr 7, 2025•
edited
Loading

In Git extension, there is an ambiguous code snippet about semantic in aswitch-case syntax amonggetStatusLetter,getStatusText andgetStatusColor static methods.

In a version control system, it may be correct ifDELETED_BY_THEM status represents a conflict rather than a NORMAL OPERATION, as the l10n code explicitly describes:

...caseStatus.DELETED_BY_THEM:returnl10n.t('Conflict: Deleted By Them');...

This fix would like to eliminate semantic ambiguity

git: make Letter/Text/Color semantically consistency

649c559

vs-code-engineeringbot assignedlszomoru

Apr 7, 2025

Copy link

Member

lszomoru commentedApr 7, 2025

@Cecil0o0, thank you very much for the contribution.
Could you please file an issue in which you are describing the issue that you are trying to address with these changes?

Copy link

ContributorAuthor

Cecil0o0 commentedApr 8, 2025•
edited
Loading

@lszomoru of course, here is a new filed issue#245993. Please have a look for my description, if something unclear please let know!

Merge branch 'main' into combine_conditions

6601dd0

Copy link

ContributorAuthor

Cecil0o0 commentedApr 11, 2025

@Cecil0o0, thank you very much for the contribution. Could you please file an issue in which you are describing the issue that you are trying to address with these changes?

@lszomoru hi, could you please have a look for this one~