- Notifications
You must be signed in to change notification settings - Fork37k
Use parameter expansion to fetch envs for envVarCollections in shellIntegration-bash.sh#245264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
To fix issue ShellIntegration-bash is not properly escaping windows pathsmicrosoft#245260where echo is causing characters to be interpreted instead of escaped
anthonykim1 commentedApr 2, 2025
Thanks for this. I agree, parameter expansion should be safer (since echo with special characters can cause some issues with those in windows path), and this would make things faster too since we avoid echo and cut (I think these spawn subprocesses) We also use the safer approachhere with env reporting stuff. |
Tyriar commentedApr 2, 2025
@meganrogge can you test this one too when you're back? |
This comment was marked as spam.
This comment was marked as spam.
meganrogge left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you!
3a28d8d intomicrosoft:mainUh oh!
There was an error while loading.Please reload this page.
…sh shell integration (#248861)Recovery release)Reverting parameter expansion in bash shell integration
To fix issue ShellIntegration-bash is not properly escaping windows paths#245260 where echo is causing characters to be interpreted instead of escaped.
#245260 issue mostly affects insider release at the moment