- Notifications
You must be signed in to change notification settings - Fork33.8k
Fix #215925#219321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix #215925#219321
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| diff = diffs.find( | ||
| d => d.lineRangeMapping.modified.startLineNumber > curLineNumber && | ||
| d.lineRangeMapping.modified.endLineNumberExclusive !== d.lineRangeMapping.modified.startLineNumber | ||
| ) ?? diffs[0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
const modifiedLineCount = this._editors.modified.getModel()!.getLineCount();if (modifiedLineCount === curLineNumber) diff = diffs[0];else diff = diffs.find(d => d.lineRangeMapping.modified.startLineNumber > curLineNumber) ?? diffs[0];I don't know if this will be better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
const modifiedLineCount = this._editors.modified.getModel()!.getLineCount();if (modifiedLineCount === curLineNumber) diff = diffs[0];else diff = diffs.find(d => d.lineRangeMapping.modified.startLineNumber > curLineNumber) ?? diffs[0];I don't know if this will be better.
This seems to be a better solution. I have updated it.
This solution also solves thefollowing issue
|
3fb7f79 intomicrosoft:mainUh oh!
There was an error while loading.Please reload this page.
Fix diff-view next/previous change loop (microsoft#215925)
fix#215925
