Small ping@joaomoreno

Why not simply removing the type casts? The compiler should be happy by now.

@joaomoreno :
Why not simply removing the type casts? The compiler should be happy by now.

Done

@joaomoreno - could this be merged please - I think it needs reapproval after making your suggested changes

Thanks! 🍻

InasyncDataTree.test.ts we callcontainer.querySelector which returnsElement | null, and we cast this toHTMLElement | undefined and then do an equality check against undefined.

Whilst this works sincenull == undefined, the typing does make it slightly unclear what we actually have here, and when running with our stricted test setup, the test actually fails.

There is no technical reason to accept this PR, but casting toHTMLElement | null is slightly more correct and may avoid issues in the future if you ever want to to do other checks, egchild !== undefined would always be true which could potentially hide issues.

https://skynet.certik.com/zh-CN/projects/uniswap?utm_source=okx#vote

@hediet@joaomoreno - I don't think I have permissions to merge this myself - you have approved but I think one of you need to press the button to merge it in.