I've downloaded this and the patch works absolutely lovely with plain Ruby files:

I don't know if this is a problem with the patch though or theCraigMaslowski.erb extension, but it doesn't work for either comment style in.html.erb files:

I don't know if this is a problem with the patch though or theCraigMaslowski.erb extension, but it doesn't work for either comment style in.html.erb files:

It seems to be a problem with the extension. The code for detecting section headers uses the region markers and comment markers from the language configuration file.That extension's language configuration file defines/* and*/ for its block comments, as well as// for its single line comments. If you make a comment using that style, you'll see the section header:

Thanks@dgileadi , I've raised an issuecraigmaslowski/vscode-erb#5 in the extension repo.

That extension is deprecated (but I still had it installed and thought VS Code). Just as a follow up, I'm actually using Shopify'sRuby LSP extension and iit's working perfectly. Hopefully soon this can be merged...

Hey@alexdima is there anything we can do as the community to help get this merged in and released? Thanks.

Thanks for the feedback,@alexdima. Your recommended changes are probably best implemented by someone familiar with the vscode code base (and of course with dedicated vscode development time). In the mean time, could you point me to the code in vscode that implements the link detection? That would help me better understand how more efficient section header detection could work.

Sure

• here is the UI side of things:

  vscode/src/vs/editor/contrib/links/browser/links.ts

  Line 34 in58558c0

  exportclassLinkDetectorextendsDisposableimplementsIEditorContribution{

• and here is the code that runs on a worker:

  vscode/src/vs/editor/common/languages/linkComputer.ts

  Line 171 in8ab34a9

  exportclassLinkComputer{

The link computation might appear a bit too complex because it goes through the language feature registry because there's vscode API for extensions to contribute link providers. Maybe a simpler example is theUnicodeHighlighter:

• the UI side:

  vscode/src/vs/editor/contrib/unicodeHighlighter/browser/unicodeHighlighter.ts

  Line 38 in8ab34a9

  exportclassUnicodeHighlighterextendsDisposableimplementsIEditorContribution{

• the worker side:

  vscode/src/vs/editor/common/services/editorSimpleWorker.ts

  Lines 396 to 402 in8ab34a9

  	publicasynccomputeUnicodeHighlights(url:string,options:UnicodeHighlighterOptions,range?:IRange):Promise<IUnicodeHighlightsResult>{
  	constmodel=this._getModel(url);
  	if(!model){
  	return{ranges:[],hasMore:false,ambiguousCharacterCount:0,invisibleCharacterCount:0,nonBasicAsciiCharacterCount:0};
  	}
  	returnUnicodeTextModelHighlighter.computeUnicodeHighlights(model,options,range);
  	}

Okay@alexdima I think I've implemented what you suggested. Let me know what you think. Thanks!

Thanks@alexdima for your attention and helpful changes!

@dgileadi I just wanted to thank you and also@alexdima,@andyjeffries, and@sandy081. I wished for this feature to exist for so many years and finally having it means the world to me. Thank you so much for all the efforts ❤️, I just opened vscode and got the update and it made my day.

Such a pleasant surprise to see this after updating VSCode. I didn't even know I wanted this, but now I already feel how it improves my life. Thank you ❤️

This is a feature I've been dreaming of! I've added MARK to my codebase before as a way to manually differentiate between codes, and now it's actually useful!❤️