- Notifications
You must be signed in to change notification settings - Fork33.8k
[typescript-language-features] Add includeCompletionsWithClassMemberSnippets preference#136045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm pretty sure we talked about enabling this by default, but just want to validate my memory on that@mjbvz@DanielRosenwasser
Thanks! |
| @@ -1110,6 +1110,12 @@ | |||
| "default": "allOpenProjects", | |||
| "markdownDescription": "%typescript.workspaceSymbols.scope%", | |||
| "scope": "window" | |||
| }, | |||
| "typescript.suggest.includeCompletionsWithClassMemberSnippets": { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Actually one quick note, I am going to split this into two settings: one for JS and one for TS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I didn't add one for JavaScript because we are not supporting this completion feature in JS yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh right! I forgot about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we are not supporting this completion feature in JS yet
But it'll come to JS sometime in the future, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think supporting JS would be nice. I created an issue to track that, feel free to upvote it:microsoft/TypeScript#46738
This PRfixesmicrosoft/TypeScript#45670
TS protocol update:microsoft/TypeScript#46370