- Notifications
You must be signed in to change notification settings - Fork33.8k
Updating the TerminalInstance to only register link providers once.#135419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
When a task reuses a terminal, the TerminalProcessManager would fire the processReady event each time a task is run, resulting in multiple registrations of the link providers. Re-registering the terminal link providers would cause xterm to trigger multiple overlapping providers on the same line of output, which is not supported by xterm at the moment. The net result is that no external link providers would work for terminals that are reused by tasks.
works well, thank you! |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a task reuses a terminal, the TerminalProcessManager would fire the processReady event each time a task is run, resulting in multiple registrations of the link providers. Re-registering the terminal link providers would cause xterm to trigger multiple overlapping providers on the same line of output, which is not supported by xterm at the moment. The net result is that no external link providers would work for terminals that are reused by tasks.
This PRfixes#134841