- Notifications
You must be signed in to change notification settings - Fork33.8k
Changing port "privacy" to "visibility" to address Codespaces user confusion#135193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…nfusionThe Codespaces product team has gotten some user feedback that the term`privacy` field of port forwarding and that the term doesn't show upelsewhere (e.g. `devcontainer.json`), so we think that we're the onlyimpacted group. Please let me know if this isn't the case.This PR is what I believe the minimal change required to change the UIto show "Visibility" vs "Privacy", though I don't claim that it'scomplete (e.g. I am not sure how we handle localization), rather, aplace to start the conversation.@alexr00, I've been told you are the right person to direct this to, andwould love to chat about this change in more detail.cc@lostintangent
/cc:@alexr00 |
alexr00 approved these changesOct 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
These should be the only places that need to be changed. Tested and it looks good.
Thanks for the quick merge@alexr00! |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The Codespaces product team has gotten some user feedback that the term
privacyfield of port forwarding is confusing. Some quick user feedback hasindicated that a term like
visibilityis more clear, e.g. "port 3000 is publiclyvisible" rather than "port 3000's privacy setting is public."
We believe that Codespaces is the only user of this term as we're not aware
of it showing up anywhere else (e.g.
devcontainer.json). Please let me knowif this isn't the case.
This PR is what I believe the minimal change required to change the UI
to show "Visibility" vs "Privacy", though I don't claim that it's
complete (e.g. I am not sure how we handle localization), rather, a
place to start the conversation.
@alexr00, I've been told you are the right person to direct this to, and
would love to chat about this change in more detail.
cc@lostintangent