- Notifications
You must be signed in to change notification settings - Fork33.8k
Add source map for every possible element in the Markdown preview#134799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
mjbvz approved these changesOct 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM! The new logic seem good and thanks for the additional cleanup!
Will be in the next insiders build and schedule to ship in stable as part of VS Code 1.62 |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PRfixes#133376
Summary
We have to clean up type definitions before the main work.
Update markdown-it and type definitions
markdown-itand its DT so that they match now.dompurifyand its DT so that they match now.@types/highlight.jsbecausehighlight.jshas its own type definitions since version 10.markdown-it. Note that lots ofanyare removed to allow TypeScript to infer type.Refresh the source map mechanism in
markdownEngine.tsaddLineNumberRenderer()withpluginSourceMapas described inAdd source map for every block-level element in the Markdown preview #133376.Note on
attrSet()andattrGet()markdown-it'sTokenis designed in a bad smell with no access control.Given
Renderer.renderAttrs()and the HTML Standard, an attribute set viaToken.attrSet()should still work even in extreme cases.The use of
Token.attrGet()is for a similar reason.