- Notifications
You must be signed in to change notification settings - Fork33.8k
Fix search editor scrolled to bottom on first search when editor group changed.#134693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks! Looking into this it seems the real culprit was failing to await the write of the results to the model before setting the view's scroll position, which meant when the contents did come in it tried to insert them "before" the existing scroll position, resulting in the document scrolling to the bottom. It's not clear to me why this only affected editors after they've been moved, perhaps something to do with the view state being stored on a per-group basis. |
Thanks. That's a much cleaner solution! |
This PRfixes#134686
I'm not sure it's the best solution, but this solves it.