Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix search editor scrolled to bottom on first search when editor group changed.#134693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JacksonKearl merged 2 commits intomicrosoft:mainfromssigwart:searchScroll
Oct 26, 2021

Conversation

ssigwart
Copy link
Contributor

This PRfixes#134686

I'm not sure it's the best solution, but this solves it.

@JacksonKearl
Copy link
Contributor

Thanks! Looking into this it seems the real culprit was failing to await the write of the results to the model before setting the view's scroll position, which meant when the contents did come in it tried to insert them "before" the existing scroll position, resulting in the document scrolling to the bottom. It's not clear to me why this only affected editors after they've been moved, perhaps something to do with the view state being stored on a per-group basis.

@JacksonKearlJacksonKearl merged commite16defc intomicrosoft:mainOct 26, 2021
@ssigwartssigwart deleted the searchScroll branchOctober 27, 2021 02:02
@ssigwart
Copy link
ContributorAuthor

Thanks. That's a much cleaner solution!

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsDec 10, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JacksonKearlJacksonKearlAwaiting requested review from JacksonKearl

Assignees

@JacksonKearlJacksonKearl

Labels
None yet
Projects
None yet
Milestone
October 2021
Development

Successfully merging this pull request may close these issues.

Search Editor is Scrolled to the Bottom if Moved to a Different Editor Group
2 participants
@ssigwart@JacksonKearl

[8]ページ先頭

©2009-2025 Movatter.jp