This still works in one pass by using negative text-indent with matching
padding to generate a CSS-based hanging indent that we can measure.
This could be upgraded to thehanging modifier in the far future. (No browsers support it at this time)

Don't ignore the indent settings in advanced wrapping mode

4acd587

Fixesmicrosoft#132220Fixesmicrosoft#120844This still works in one pass by using negative text-indent with matchingpadding to generate a CSS-based hanging indent that we can measure.This could be upgraded to the `hanging` modifier in the far future.

Copy link

ghost commentedSep 29, 2021•
edited by ghost
Loading

All CLA requirements met.

byteit101 mentioned this pull request

Sep 29, 2021

Wrapping & indent broken when used together for non-monospace glyphs (proportional fonts or non-latin chars)#132220

Closed

vscode-triage-bot assignedalexdima

Sep 29, 2021

Copy link

ContributorAuthor

byteit101 commentedSep 29, 2021•
edited
Loading

Text I used to verify this fix (I didn't see any advanced wrapping test file):

W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W W Wi i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i i iThis is a normal long line that has normal words on it. No abnormal words here, though maybe that last one could count as one.Very wide glyphs:𒅃 𒈓 𒍼 𒅃 𒌧 𒅃 𒈓 𒍼 𒅃 𒌧 𒅃 𒈓 𒍼 𒅃 𒌧 𒅃 𒈓 𒍼 𒅃 𒌧 𒅃 𒈓 𒍼 𒅃 𒌧 𒈓 𒍼 𒅃 𒌧 𒈓 𒍼𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫 𒐫﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽ ﷽Above is U+12143, U+12213, U+1237C, U+12327 (Cuneiform block characters), then U+1242B (CUNEIFORM NUMERIC SIGN NINE SHAR2), then finally U+FDFD (ARABIC LIGATURE BISMILLAH AR-RAHMAN AR-RAHEEM)

Screenshots of correctly wrapping & indenting with this change:

Monospace font (wide non-Latin characters fixed):