Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove angle brackets when checking the scheme#133419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mjbvz merged 2 commits intomicrosoft:mainfromcodingLogan:markdown-angle-brackets
Oct 4, 2021

Conversation

codingLogan
Copy link
Contributor

Summary

When the link is being checked for a known scheme in a markdown file, the scheme wasn't being recognized when encased inside of angle brackets < and >. This change strips the link of beginning and ending < and > so the scheme can be properly checked.

This only removes the brackets during the scheme check if the initial link provided actually has angle brackets. Otherwise it will just use the given link as usual.

Issue

This PRfixes#132974

Testing (Currently Released Build)

Begin editing a markdown file, and enter the following text into the file. If you attempt tocommand + click orcontrol + click the link in the markdown file you are editing, it won't open in a browser. (note it will open from the markdown preview, just not the editable markdown file)

[Bad - Opens file](<http://google.com>)

Testing (Fixes)

With the code changes applied, you can enter the same text in a markdown file, and the link will open up as expected in the browser. (and it will still open from the markdown preview).

This only removes the brackets during the scheme check if the initial link provided actually has angle brackets.
Copy link
Collaborator

@mjbvzmjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for taking a look. Just a few minor points of feedback

@mjbvzmjbvz added this to theOctober 2021 milestoneSep 27, 2021
Change to use replace instead of match for easier reading
@codingLogan
Copy link
ContributorAuthor

@mjbvz I made those changes you suggested, and thank you for reviewing the PR. Let me know of any further changes you may think of.

@mjbvzmjbvz merged commit35ea6c0 intomicrosoft:mainOct 4, 2021
@mjbvz
Copy link
Collaborator

Thanks!

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 18, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mjbvzmjbvzAwaiting requested review from mjbvz

Assignees

@mjbvzmjbvz

Labels
None yet
Projects
None yet
Milestone
October 2021
Development

Successfully merging this pull request may close these issues.

Syntax Highlighting and Opening Link error in Markdown file
2 participants
@codingLogan@mjbvz

[8]ページ先頭

©2009-2025 Movatter.jp