Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix codeblock detection to catch blocks not on first lines#132821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mjbvz merged 1 commit intomicrosoft:mainfromGerrit0:fix/codeblock-detection
Oct 7, 2021

Conversation

Gerrit0
Copy link
Contributor

This PRfixes#132820

@mjbvz
Copy link
Collaborator

Thanks for the PR! I think this makes sense but can you also add some tests to make sure we are doing the correct thing and don't regress this in the future:

@mjbvzmjbvz added this to theSeptember 2021 milestoneSep 10, 2021
@mjbvz
Copy link
Collaborator

One thing actually: we need to support@example without fenced code blocks:https://jsdoc.app/tags-example.html

For those cases, the text should be treated as if it was a code block even though there is no explicit fenced code block

@Gerrit0
Copy link
ContributorAuthor

@mjbvz am I missing something obvious here? I tried to follow the instructions athttps://github.com/microsoft/vscode/blob/main/test/unit/README.md to run the tests (with--grep typescript.previewer since there are entirely too many). This command can't seem to find the tests.
Running withyarn run mocha --ui tdd --run ./extensions/typescript-language-features/src/test/unit/previewer.test.ts can't find the file (it replaces the ts extension with js). If I try to run the built file in a way that I'd expect to work,yarn test .\extensions\typescript-language-features\out\test\unit\previewer.test.js, it can't findvscode

@mjbvz
Copy link
Collaborator

You can run them through VS Code's debug view:

Screen Shot 2021-09-14 at 11 59 55 AM

@mjbvzmjbvz removed this from theSeptember 2021 milestoneSep 16, 2021
@Gerrit0
Copy link
ContributorAuthor

Thanks! No wonder I didn't see that... have never really heavily used the debugger for tests.

Test cases:

/** *@example * foo(); * *@example * Caption * ```ts * foo(); * ``` */functionfoo(){}

image

/** *@example <caption>Caption</caption> * bar(); * *@example <caption>Caption</caption> * ```ts * bar(); * ``` */functionbar(){}

image

@Gerrit0
Copy link
ContributorAuthor

Disabled tests were failing, unrelated to my changes.

Copy link
Collaborator

@mjbvzmjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM besides the comments

@mjbvzmjbvz added this to theOctober 2021 milestoneSep 27, 2021
@Gerrit0Gerrit0 reopened thisSep 29, 2021
@mjbvzmjbvz merged commit3629e68 intomicrosoft:mainOct 7, 2021
@mjbvz
Copy link
Collaborator

Thanks! This change will in the next VS Code 1.62 insiders build

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 21, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mjbvzmjbvzmjbvz requested changes

@atlslscsrv-appatlslscsrv-appatlslscsrv-app approved these changes

Assignees

@mjbvzmjbvz

Labels
None yet
Projects
None yet
Milestone
October 2021
Development

Successfully merging this pull request may close these issues.

TSDoc @example tag is improperly handled in previews
4 participants
@Gerrit0@mjbvz@atlslscsrv-app@roblourens

[8]ページ先頭

©2009-2025 Movatter.jp