- Notifications
You must be signed in to change notification settings - Fork33.8k
Fix codeblock detection to catch blocks not on first lines#132821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR! I think this makes sense but can you also add some tests to make sure we are doing the correct thing and don't regress this in the future:
|
One thing actually: we need to support For those cases, the text should be treated as if it was a code block even though there is no explicit fenced code block |
@mjbvz am I missing something obvious here? I tried to follow the instructions athttps://github.com/microsoft/vscode/blob/main/test/unit/README.md to run the tests (with |
Thanks! No wonder I didn't see that... have never really heavily used the debugger for tests. Test cases: /** *@example * foo(); * *@example * Caption * ```ts * foo(); * ``` */functionfoo(){} /** *@example <caption>Caption</caption> * bar(); * *@example <caption>Caption</caption> * ```ts * bar(); * ``` */functionbar(){} |
eb226ae
to0c486c8
CompareDisabled tests were failing, unrelated to my changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM besides the comments
extensions/typescript-language-features/src/test/smoke/referencesCodeLens.test.ts OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
extensions/typescript-language-features/src/test/unit/previewer.test.ts OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
0c486c8
to8e35bdb
Compare91260e0
tof44b621
Comparef44b621
to981c7f7
CompareThanks! This change will in the next VS Code 1.62 insiders build |
This PRfixes#132820