Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Integrate Source Code into Disassembly View#132541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
roblourens merged 16 commits intomicrosoft:mainfromyuehuang010:dev/yuehuang/main_dap
Oct 21, 2021
Merged

Integrate Source Code into Disassembly View#132541

roblourens merged 16 commits intomicrosoft:mainfromyuehuang010:dev/yuehuang/main_dap
Oct 21, 2021

Conversation

yuehuang010
Copy link
Contributor

@yuehuang010yuehuang010 commentedSep 7, 2021
edited
Loading

Feature: Integrate Source Code into Disassembly View

  • Add Toggle Action to Show/Hide source code.
  • Go-To-Source with line number on double click.
  • Fix line-height to be more precise and default to match Monaco's default.
  • Fixed remove all bp in the BP View to also remove Instruction Breakpoints.
  • Fixed an issue when scrolling too fast to incorrectly load the wrong disassembly.

image
image

This PR fixes some of the issues in#129762

krk reacted with hooray emoji
@yuehuang010yuehuang010 changed the titleDev/yuehuang/main dapIntegrate Source Code into Disassembly ViewSep 7, 2021
@yuehuang010
Copy link
ContributorAuthor

@isidorn@roblourens

@weinandweinand added the debugDebug viewlet, configurations, breakpoints, adapter issues labelSep 8, 2021
@weinand
Copy link
Contributor

@yuehuang010 while reviewing and verifying the PR, I noticed that I can only set a breakpoint in a disassembly line that has the yellow current location:

2021-09-08_15-34-13 (1)

This must be bug and not the expected behavior, right?

@weinandweinand assignedroblourens and unassignedweinandSep 8, 2021
@yuehuang010
Copy link
ContributorAuthor

yuehuang010 commentedSep 8, 2021
edited
Loading

@weinand I got a repro, thanks. The click box is squashed due to "flex-end".I need to investigate an alternative. Fixed.

@weinand
Copy link
Contributor

@yuehuang010 thanks, setting breakpoints works now.

@weinand
Copy link
Contributor

@yuehuang010@roblourens in order to verify the "Show/Hide source code" feature I've added "source/line" attributes to disassembly instructions in Mock Debug (published on the Marketplace): the first instruction from a new source line has a corresponding "source/line" attribute:

2021-09-09_18-10-45 (1)

I noticed a few things:

  • the "Show/Hide source code" command is not discoverable, e.g. there is no context menu or editor action. Only clicking in an instruction with source will show the source.
  • the "Show source code" does not seem to reveal/highlight the correct source line. Only the correct source editor is opened/revealed.
  • hitting an instruction breakpoint sometimes reveals the line at the top of the view port which results in back and forth jumping:
    2021-09-09_18-21-09 (1)

@yuehuang010
Copy link
ContributorAuthor

the "Show/Hide source code" command is not discoverable, e.g. there is no context menu or editor action. Only clicking in an > instruction with source will show the source.
A context menu is planned but out of scope for this PR. So I added other means like F1 command and Settings UI. This and copy and paste would be added once a context menu is added.

the "Show source code" does not seem to reveal/highlight the correct source line. Only the correct source editor is opened/revealed.
Did you supply add column information? It should select the span. Without column it would jump to line without selection.

@weinand

@weinand
Copy link
Contributor

No, I did not provide a column, only the line. But even the line is not selected.

@yuehuang010
Copy link
ContributorAuthor

@weinand , just pushed two fixes. The the entire line is selected on open file and stepping should reveal/follow new address.

@yuehuang010
Copy link
ContributorAuthor

@roblourens Do you have any questions?

@roblourensroblourens added this to theSeptember 2021 milestoneSep 21, 2021
@roblourens
Copy link
Member

Sep-21-2021 15-25-50
horizontal scrolling is not working correctly for me

@xisui-MSFT
Copy link
Contributor

Sep-21-2021 15-25-50
horizontal scrolling is not working correctly for me

@yuehuang010 Horizontal scrolling has never been supported by WorkbenchTable. Please disable it.

@yuehuang010
Copy link
ContributorAuthor

Sep-21-2021 15-25-50
horizontal scrolling is not working correctly for me

@yuehuang010 Horizontal scrolling has never been supported by WorkbenchTable. Please disable it.

I missed reverting when testing.

@yuehuang010
Copy link
ContributorAuthor

@roblourens@weinand@isidorn Could you please review this?

@roblourens
Copy link
Member

roblourens commentedOct 20, 2021
edited
Loading

Just the two remaining open discussions - when those are resolved, I can merge it. Would like to do that this week :)

@yuehuang010
Copy link
ContributorAuthor

Just the two remaining open discussions - when those are resolved, I can merge it. Would like to do that this week :)

Pushed.

roblourens reacted with hooray emoji

@roblourensroblourens merged commitdf62644 intomicrosoft:mainOct 21, 2021
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsDec 5, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@xisui-MSFTxisui-MSFTxisui-MSFT left review comments

@roblourensroblourensroblourens approved these changes

Assignees

@roblourensroblourens

Labels
debugDebug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Milestone
October 2021
Development

Successfully merging this pull request may close these issues.

4 participants
@yuehuang010@weinand@roblourens@xisui-MSFT

[8]ページ先頭

©2009-2025 Movatter.jp