- Notifications
You must be signed in to change notification settings - Fork33.8k
Integrate Source Code into Disassembly View#132541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@yuehuang010 while reviewing and verifying the PR, I noticed that I can only set a breakpoint in a disassembly line that has the yellow current location: This must be bug and not the expected behavior, right? |
yuehuang010 commentedSep 8, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@weinand I got a repro, thanks. The click box is squashed due to "flex-end". |
@yuehuang010 thanks, setting breakpoints works now. |
@yuehuang010@roblourens in order to verify the "Show/Hide source code" feature I've added "source/line" attributes to disassembly instructions in Mock Debug (published on the Marketplace): the first instruction from a new source line has a corresponding "source/line" attribute: I noticed a few things:
|
|
No, I did not provide a column, only the line. But even the line is not selected. |
@weinand , just pushed two fixes. The the entire line is selected on open file and stepping should reveal/follow new address. |
@roblourens Do you have any questions? |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
@yuehuang010 Horizontal scrolling has never been supported by WorkbenchTable. Please disable it. |
Uh oh!
There was an error while loading.Please reload this page.
I missed reverting when testing. |
@roblourens@weinand@isidorn Could you please review this? |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
…. Fix goto to use default reveal.
roblourens commentedOct 20, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Just the two remaining open discussions - when those are resolved, I can merge it. Would like to do that this week :) |
Pushed. |
Uh oh!
There was an error while loading.Please reload this page.
Feature: Integrate Source Code into Disassembly View
This PR fixes some of the issues in#129762