Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add colorized bracket highlighting colours#132494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

TabithaLarkin
Copy link
Contributor

@TabithaLarkinTabithaLarkin commentedSep 6, 2021
edited by hediet
Loading

This PRfixes#132493

As suggested inthis comment by@hediet.

This shows an preview of what these colours would look like (generated from adding these settings to my local settings.json file.

image

edit by@hediet:

With default colors:

Without bracket pair colorization:

@hediet
Copy link
Member

hediet commentedSep 6, 2021
edited
Loading

Thanks! Can you post a before/after screenshot of the same code region, so that it becomes very clear what the difference is?

@hediethediet self-assigned thisSep 6, 2021
@hediethediet added this to theSeptember 2021 milestoneSep 6, 2021
@TabithaLarkin
Copy link
ContributorAuthor

Ah, I've already added those screenshots to the issue that I raised, with the bracket colorization off and on too.

@hediet
Copy link
Member

hediet commentedSep 6, 2021
edited
Loading

@roblourens what do you think (I think it is your theme)?

@roblourens
Copy link
Member

Not me :)

@roblourens
Copy link
Member

roblourens commentedSep 9, 2021
edited
Loading

I don't think that individual themes have owners. You could run it by @misolori if you want another opinion. Looks fine to me though.

@hediet
Copy link
Member

@misolori What do you think?

@miguelsolorio
Copy link
Contributor

miguelsolorio commentedSep 10, 2021
edited
Loading

Here's a snapshot of the theme colors + bracket colors with the original vs the proposed colors:

CleanShot 2021-09-10 at 09 10 02@2x

I'd probably keep the bracket colors closer to the original so this is what I would suggest:

"editorBracketHighlight.foreground1":"#b58800","editorBracketHighlight.foreground2":"#d33682","editorBracketHighlight.foreground3":"#0B75BF",

CleanShot 2021-09-10 at 09 12 54@2x

Before

CleanShot 2021-09-10 at 09 13 50@2x

After

CleanShot 2021-09-10 at 09 16 20@2x

@TabithaLarkin
Copy link
ContributorAuthor

The reason I selected the white colour was because that was what the standard colour of the brackets without any bracket pair colorization. I would also caution against using the blue colour as it's the same colour as the text, which somewhat removes the benefit of colour differences in IDEs.

image

CoenraadS reacted with thumbs up emoji

@miguelsolorio
Copy link
Contributor

The reason I selected the white colour was because that was what the standard colour of the brackets without any bracket pair colorization

Doesn't this conflict with the feature? I think we'd want to mirror the original as close as possible while still matching the theme

I would also caution against using the blue colour as it's the same colour as the text, which somewhat removes the benefit of colour differences in IDEs

Fair point, I think an alternate color can work here as well

@hediet
Copy link
Member

Doesn't this conflict with the feature? I think we'd want to mirror the original as close as possible while still matching the theme

I think it is actually not a bad idea to use white as one of three (or more) colors for specific themes: This feature is all about being able to see matching bracket pairs, not neccessarily about highlighting brackets from text.
The original extension does not support themeable colors anyway.

@hediethediet modified the milestones:September 2021,BacklogSep 14, 2021
@hediethediet removed their assignmentOct 11, 2021
@TabithaLarkin
Copy link
ContributorAuthor

@misolori Is there anything I can do to get this over the line? What's the blocker here?

Copy link
Contributor

@miguelsoloriomiguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the ping, LGTM let's get this merged and see how it looks like on Insiders. Thank you!

@miguelsoloriomiguelsolorio merged commitfba6ce5 intomicrosoft:mainOct 19, 2021
@TabithaLarkinTabithaLarkin deleted the TabithaLarkin/DarkSolarizedColorizedBrackets branchOctober 20, 2021 01:45
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsDec 3, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@miguelsoloriomiguelsoloriomiguelsolorio approved these changes

Assignees

@miguelsoloriomiguelsolorio

Projects
None yet
Milestone
October 2021
Development

Successfully merging this pull request may close these issues.

Add bracket pair colorization settings for Solarized Dark theme
4 participants
@TabithaLarkin@hediet@roblourens@miguelsolorio

[8]ページ先頭

©2009-2025 Movatter.jp