Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Terminal now supports linking local file paths containing '$'#132027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Tyriar merged 3 commits intomicrosoft:mainfrombrajkowski:issue-129911
Oct 22, 2021
Merged

Terminal now supports linking local file paths containing '$'#132027

Tyriar merged 3 commits intomicrosoft:mainfrombrajkowski:issue-129911
Oct 22, 2021

Conversation

brajkowski
Copy link
Contributor

Fixes#129911

@meganroggemeganrogge added this to theOctober 2021 milestoneOct 1, 2021
@ghost
Copy link

ghost commentedOct 22, 2021•
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

Copy link
Member

@TyriarTyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Works great thanks, I added tests for it too

brajkowski reacted with thumbs up emoji
@TyriarTyriar merged commitb6aa001 intomicrosoft:mainOct 22, 2021
@Tyriar
Copy link
Member

Tyriar commentedOct 22, 2021•
edited
Loading

Opps I see you didn't sign the CLA, this should be fine as the PR is super trivial (reverting the change and redoing the 2 $ removals would be silly). For any future PRs you will want to sign the CLA.

@brajkowski
Copy link
ContributorAuthor

Thanks@Tyriar! I just signed the CLA too -- sorry about that!

Tyriar reacted with thumbs up emoji

@brajkowskibrajkowski deleted the issue-129911 branchOctober 25, 2021 01:44
@Tyriar
Copy link
Member

Cheers 🙂

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsDec 6, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@TyriarTyriarTyriar approved these changes

Assignees

@TyriarTyriar

Labels
None yet
Projects
None yet
Milestone
October 2021
Development

Successfully merging this pull request may close these issues.

Clicking on terminal in a pathname that contains a $ doesn't open the file
3 participants
@brajkowski@Tyriar@meganrogge
[8]ページ先頭
©2009-2025 Movatter.jp