- Notifications
You must be signed in to change notification settings - Fork33.8k
Add setting to control hover position#127609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This adds a hover setting to control whether the user wants hovers to appear above or below the relevant line, if there's space.Fixesmicrosoft#78560
Any chance of a review of this before it gets conflicted to death? |
steinhh commentedOct 27, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This is almost certainly not the right place for this comment, but sorry: It seems like an incredibly small and simple change to review and merge! And it seems like such a no-brainer... most (99%+) programmers write their code starting at the top with the first line, not at the bottom with the last line... so covering up stuff you've just written, above where you're currently writing, seems like the wrong thing (to 99%+ of users). |
You're right and I'm sorry for being so slow looking at this. @Timmmm thank you for the high quality contribution and apologies for being unresponsive. |
No worries - thanks for merging it! :-) |
This adds a hover setting to control whether the user wants hovers to appear above or below the relevant line, if there's space.
Tested manually, including when the hover is near the bottom of the editor and this option is enabled.
This PRfixes#78560