- Notifications
You must be signed in to change notification settings - Fork33.8k
Closed
Assignees
Labels
feature-requestRequest for new features or functionalitygood first issueIssues identified as good for first-time contributorshelp wantedIssues identified as good community contribution opportunitiespolishCleanup and polish issueterminalGeneral terminal issues that don't fall under another labelverification-neededVerification of issue is requestedverifiedVerification succeeded
Milestone
Description
Does this issue occur when all extensions are disabled?: Yes
- VS Code Version:
Version: 1.59.1Commit: 3866c3553be8b268c8a7f8c0482c0c0177aa8bfaDate: 2021-08-19T11:53:52.479Z (3 days ago)Electron: 13.1.7Chrome: 91.0.4472.124Node.js: 14.16.0V8: 9.1.269.36-electron.0OS: Darwin x64 20.5.0- OS Version: macOS 11.4
Steps to Reproduce:
- Launch vscode with
code --disable-extensions - Press
cmd+shift+p, runTerminal: Create Terminal in Editor Area
I'm using zsh with the popularpure prompt, which will start a childzsh process. See more at:sindresorhus/pure#215
It seems vscode already ignores some processes. Would it be a better way to provide a custom setting to ignore processes?
vscode/src/vs/platform/terminal/node/childProcessMonitor.ts
Lines 25 to 31 in3866c35
| constignoreProcessNames=[ | |
| // Popular prompt programs, these should not count as child processes | |
| 'starship', | |
| 'oh-my-posh', | |
| // Git bash may runs a subprocess of itself (bin\bash.exe -> usr\bin\bash.exe) | |
| 'bash', | |
| ]; |
Metadata
Metadata
Assignees
Labels
feature-requestRequest for new features or functionalitygood first issueIssues identified as good for first-time contributorshelp wantedIssues identified as good community contribution opportunitiespolishCleanup and polish issueterminalGeneral terminal issues that don't fall under another labelverification-neededVerification of issue is requestedverifiedVerification succeeded