Commitad4130b

authored and

committed

Do not check for navigator to detect web environment in built-in extensions (#251688)

Do not check for navigator to detect web environment

1 parentcd3c36a commitad4130bCopy full SHA for ad4130b

File tree

-3

lines changed

extensions
- simple-browser/src
  - extension.ts
- typescript-language-features/src/utils
  - platform.ts

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -87,5 +87,5 @@ export function activate(context: vscode.ExtensionContext) {`
`87`	`87`
`88`	`88`	`functionisWeb():boolean{`
`89`	`89`	`//@ts-expect-error`
`90`		`-returntypeofnavigator!=='undefined'&&vscode.env.uiKind===vscode.UIKind.Web;`
	`90`	`+return!(typeofprocess==='object'&&!!process.versions.node)&&vscode.env.uiKind===vscode.UIKind.Web;`
`91`	`91`	`}`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`import*asvscodefrom'vscode';`
`7`	`7`
`8`	`8`	`exportfunctionisWeb():boolean{`
`9`		`-return'navigator'inglobalThis&&vscode.env.uiKind===vscode.UIKind.Web;`
	`9`	`+return!(typeofprocess==='object'&&!!process.versions.node)&&vscode.env.uiKind===vscode.UIKind.Web;`
`10`	`10`	`}`
`11`	`11`
`12`	`12`	`exportfunctionisWebAndHasSharedArrayBuffers():boolean{`
`@@ -16,4 +16,3 @@ export function isWebAndHasSharedArrayBuffers(): boolean {`
`16`	`16`	`exportfunctionsupportsReadableByteStreams():boolean{`
`17`	`17`	`returnisWeb()&&'ReadableByteStreamController'inglobalThis;`
`18`	`18`	`}`
`19`		`-`

Comments

(0)