@rbuckton Can you take a look at this?

@SoulPancake Sorry for jumping on here for a slightly tangential issue, but I noticed that nil checks are inconsistent throughout the codebase. For example,

https://github.com/microsoft/typescript-go/blob/main/internal%2Fast%2Fast.go#L15-L31

typeVisitorfunc(*Node)boolfuncvisit(vVisitor,node*Node)bool {ifnode!=nil {returnv(node)        }returnfalse}funcvisitNodes(vVisitor,nodes []*Node)bool {for_,node:=rangenodes {ifv(node) {returntrue                }        }returnfalse}

visit checks for nils, but the for loop doesn't check ifnode is nil. Do you have clear documentation on whetherVisitors are supposed to handle nils? Becausevisit assumes they don't, andvisitNodes assumes they do, which are mutually incompatible assumptions.

@SaadiSave Agreed, I will add the nil check in the loop

@SoulPancake is there a lint to enforce nil checks?

Don't think so@SaadiSave

This PR has gotten out of date as main changed. Could you update it, or close it if you don't plan on working on this anymore?

I will update it asap@jakebailey

@jakebailey Done, Can you take a look at this?

I feel like most of these are redundant; I would think we'd only want ones that correspond to undefined checks in the original code.