- Notifications
You must be signed in to change notification settings - Fork664
Add issue templates#1410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Add issue templates#1410
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
--- | ||
name:Crash | ||
about:Using tsgo or the language server caused a panic | ||
title:'' | ||
labels:Crash | ||
assignees:'' | ||
--- | ||
##Stack trace | ||
``` | ||
[paste stack trace here] | ||
``` | ||
##Steps to reproduce | ||
1. |
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,16 @@ | ||||||||||
--- | ||||||||||
name:Behavior Difference | ||||||||||
about:tsgo produces different results than TypeScript 5.8 | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Suggested change
Suggested change
| ||||||||||
title:'' | ||||||||||
labels:'' | ||||||||||
assignees:'' | ||||||||||
--- | ||||||||||
##Steps to reproduce | ||||||||||
<!-- Share a repository link or a code sample--> | ||||||||||
##Behavior with`typescript@5.8` | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Suggested change
Not sure if specifically calling out There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. It was, since using a too-new or too-old version could explain the behavior difference. | ||||||||||
##Behavior with`tsgo` |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
--- | ||
name: Other | ||
about: Something else | ||
title: '' | ||
labels: '' | ||
assignees: '' | ||
--- | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
--- | ||
name: '[TypeScript Team Use] Copilot PR porting' | ||
about: Instructions for Copilot to port a PR from microsoft/TypeScript | ||
title: 'Port TypeScript PR #[NNNNN]' | ||
labels: Porting PR | ||
assignees: '' | ||
--- | ||
This repository is a port of microsoft/TypeScript from TypeScript to Go. Since the port began, the following pull request was applied to microsoft/TypeScript. An equivalent change now needs to be applied here. | ||
## PR to port | ||
- PR link: <!-- https://github.com/microsoft/TypeScript/pull/NNNNN --> | ||
andrewbranch marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
- Squash commit diff: <!-- Copy the squash commit link and append ".patch", e.g. https://github.com/microsoft/TypeScript/commit/a271797c1a95494e5f7aa8075c01941ad25cad08.patch --> | ||
## Instructions | ||
1. Use `playwright` to view the PR listed above | ||
2. Apply the edits made in that PR to this codebase, translating them from TypeScript to Go. | ||
- The change may or may not be applicable. It may have already been ported. Do not make any significant changes outside the scope of the diff. If the change cannot be applied without significant out-of-scope changes, explain why and stop working. | ||
- Tip: search for functions and identifiers from the diff to find the right location to apply edits. Some files in microsoft/TypeScript have been split into multiple. | ||
- Tip: some changes have already been ported, like changes to diagnostic message text. Tests do not need to be ported as they are imported from the submodule. | ||
3. Refer to your copilot_instructions.md for guidance on how to build and test your change. Note the following differences to the typical development workflow: | ||
- Since you are porting the implementation for a behavior that already has tests in the submodule, you don't need to add new tests. Instead, your change should change existing baselines. | ||
- If done correctly, you should see removals in `.diff` baselines. These `.diff` removals are your ultimate source of truth: your change is not correct unless diffs are reduced. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Nit: diffs might be introduced or modified if there are new paths that are triggered. So at leastsome diffs should be reduced or eliminated, but I wonder if a model would take this too literally. I'm flexible about trying whatever you think is right here though. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. My experience has been that it's hard to convince the agent to minimize the diffs. |
Uh oh!
There was an error while loading.Please reload this page.