- Notifications
You must be signed in to change notification settings - Fork664
Add issue templates#1410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add issue templates#1410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR adds GitHub issue templates to help standardize issue reporting and facilitate specific workflows for the TypeScript-to-Go port project. The templates provide structured forms for different types of issues and automated workflows.
- Adds templates for crash reports, behavior differences, and general issues
- Creates a specialized template for Copilot to port PRs from microsoft/TypeScript
- Establishes consistent labeling and assignment patterns for issue management
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/ISSUE_TEMPLATE/crash.md | Template for crash reports with stack trace and reproduction steps |
.github/ISSUE_TEMPLATE/behavior-difference.md | Template for reporting differences between tsgo and TypeScript 5.8 behavior |
.github/ISSUE_TEMPLATE/copilot-pr-porting.md | Specialized template with instructions for Copilot to port PRs from upstream |
.github/ISSUE_TEMPLATE/other.md | Generic template for miscellaneous issues |
| @@ -0,0 +1,16 @@ | |||
| --- | |||
| name:Behavior Difference | |||
| about:tsgo produces different results than TypeScript 5.8 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| about: tsgo produces different results than TypeScript 5.8 | |
| about: tsgo produces different results than TypeScript 5.x |
| about: tsgo produces different results than TypeScript 5.8 | |
| about: tsgo produces different results than TypeScript 5.8+ |
| <!-- Share a repository link or a code sample--> | ||
| ##Behavior with`typescript@5.8` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| ##Behavior with`typescript@5.8` | |
| ##Behavior with`typescript@5.x` |
Not sure if specifically calling out5.8 was intentional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It was, since using a too-new or too-old version could explain the behavior difference.
Uh oh!
There was an error while loading.Please reload this page.
| - Tip: some changes have already been ported, like changes to diagnostic message text. Tests do not need to be ported as they are imported from the submodule. | ||
| 3. Refer to your copilot_instructions.md for guidance on how to build and test your change. Note the following differences to the typical development workflow: | ||
| - Since you are porting the implementation for a behavior that already has tests in the submodule, you don't need to add new tests. Instead, your change should change existing baselines. | ||
| - If done correctly, you should see removals in `.diff` baselines. These `.diff` removals are your ultimate source of truth: your change is not correct unless diffs are reduced. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nit: diffs might be introduced or modified if there are new paths that are triggered. So at leastsome diffs should be reduced or eliminated, but I wonder if a model would take this too literally. I'm flexible about trying whatever you think is right here though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
My experience has been that it's hard to convince the agent to minimize the diffs.
Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
d0520d8Uh oh!
There was an error while loading.Please reload this page.
No description provided.