- Notifications
You must be signed in to change notification settings - Fork8.9k
teach wil about c++/winrt exceptions by including cppwinrt.h#2927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
zadjii-msft left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we maybe add a note about this bug where we're including this?
DHowett-MSFT commentedSep 28, 2019
I'm not sure. It's also just a matter of general correctness to do this. It's also got green builds, and if I rev it to add a comment the builds will ungreen themselves... |
ghost commentedOct 4, 2019
🎉 Handy links: |
It turns out that if you CATCH_LOG without including this file, and you
end up catching a C++/WinRT hresult_exception, IT TURNS IT INTO A
FAILFAST.
Fixes#2591
Fixes#2881
Fixes#2807
PR Checklist
Requires documentation to be updatedValidation Steps Performed
Really went ham on the clipboard. Like, wow.