Commit351d326

committed

Revert "Patch fix for#1360 until WriteStream (#780) can be implemented. (#2924)"

This reverts commit776b9a5.

1 parent2f2636f commit351d326Copy full SHA for 351d326

File tree

-105

lines changed

-105

lines changed

Lines changed: 0 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -416,18 +416,6 @@ void Terminal::_WriteBuffer(const std::wstring_view& stringView)`
`416`	`416`	`}`
`417`	`417`	`}`
`418`	`418`
`419`		`-// If we're about to try to place the cursor past the right edge of the buffer, move it down a row`
`420`		`-// This is another patch that GH#780 should supersede. This is really correcting for other bad situations`
`421`		`-// like bisecting (writing only the leading half because there's no room for the trailing) a wide character`
`422`		`-// into the buffer. However, it's not really all-up correctable without implementing a full WriteStream here.`
`423`		`-// Also, this particular code RIGHT HERE shouldn't need to know anything about the cursor or the cells advanced`
`424`		`-// which also will be solved by GH#780 (hopefully).`
`425`		`-if (proposedCursorPosition.X > bufferSize.RightInclusive())`
`426`		`- {`
`427`		`- proposedCursorPosition.X =0;`
`428`		`- proposedCursorPosition.Y++;`
`429`		`- }`
`430`		`-`
`431`	`419`	`// If we're about to scroll past the bottom of the buffer, instead cycle the buffer.`
`432`	`420`	`constauto newRows = proposedCursorPosition.Y - bufferSize.Height() +1;`
`433`	`421`	`if (newRows >0)`

Lines changed: 0 additions & 92 deletions

This file was deleted.

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,6 @@`
`9`	`9`	`<ClCompileInclude="precomp.cpp">`
`10`	`10`	`<PrecompiledHeader>Create</PrecompiledHeader>`
`11`	`11`	`</ClCompile>`
`12`		`- <ClCompileInclude="TerminalApiTests.cpp" />`
`13`	`12`	`</ItemGroup>`
`14`	`13`	`<ItemGroup>`
`15`	`14`	`<ProjectReferenceInclude="..\..\buffer\out\lib\bufferout.vcxproj">`

Comments

(0)