Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add children to the props for @types/react@18#192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ChromeQ wants to merge2 commits intomicrosoft:masterfromChromeQ:master

Conversation

@ChromeQ
Copy link

In relation to React props should not do anything special withchildren and DefinitelyTyped have updated the react types to v18

DefinitelyTyped/DefinitelyTyped#59802

Pabliomen, sea-rtenorio, dhassouni, simon-rad, ymainier, mantaskemesius, and davoam reacted with thumbs up emoji
Copy link

@dhassounidhassouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looks good, low risk

@simon-rad
Copy link

Any update here? No way to switch to React 18 without this fix

@ChromeQ
Copy link
Author

Can we get this merged?

@abettadapur
Copy link
Collaborator

I am unfortunately not an admin on this project anymore, so I am unable to bypass a broken CI check

@rishab85
Copy link

Any update on this ? it would be nice if could merge this PR.

@tvanrijn
Copy link

Can this get merged and released? Waiting on this fix.

@avianate
Copy link

Any updates on when this will be merged?

@dagadbm
Copy link

Any updates? This is blocking any ability to upgrade to react 18

@ChromeQChromeQ closed this by deleting the head repositoryOct 4, 2025
@dagadbm
Copy link

why was this deleted?

@ChromeQ
Copy link
Author

I was cleaning up my personal repos and didn't realise it was linked to an open PR.
I also have zero confidence this will get merged as the project seems dead with last commit almost 3 years ago, plus I personally moved on from using redux-dynamic-modules. Sorry.

The PR changes are still visible so you can create your own fork if you were relying on it.

@dagadbm
Copy link

can you share how you moved away from it?

@ChromeQ
Copy link
Author

can you share how you moved away from it?

I meant that I don't maintain the project which used this, in my new project I don't use Redux at all and use react context and providers instead.

You can also use patch-package to apply these changes in your local node_modules rather than fork or maintain a package

@dagadbm
Copy link

seems we can get away by just doing this:

#193

underglobal.d.ts i just created this file on the root of my frontend code

// https://github.com/microsoft/redux-dynamic-modules/issues/193import * as _ from 'redux-dynamic-modules-react';declare module 'redux-dynamic-modules-react' {  export interface IDynamicModuleLoaderProps {    children: React.ReactNode;  }}

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@abettadapurabettadapurabettadapur approved these changes

+5 more reviewers

@avianateavianateavianate approved these changes

@dhassounidhassounidhassouni approved these changes

@dagadbmdagadbmdagadbm approved these changes

@robtenoriorobtenoriorobtenorio approved these changes

@sea-dhassounisea-dhassounisea-dhassouni approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@ChromeQ@simon-rad@abettadapur@rishab85@tvanrijn@avianate@dagadbm@dhassouni@robtenorio@sea-dhassouni

[8]ページ先頭

©2009-2025 Movatter.jp