Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Fabric] Enable ShadowProps for all Fabric Components#12108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@TatianaKapos
Copy link
Contributor

@TatianaKaposTatianaKapos commentedSep 5, 2023•
edited
Loading

Description

Finish implementing ShadowProps for other components in Fabric (Text, Image, TextInput, ScrollView, ActivityIndicator, Switch)

Type of Change

  • New feature (non-breaking change which adds functionality)

Why

Resolves#11754

What

Extracted logic from View Component to Base Component for ShadowProps. Named helper methodupdateStyleProps so we can extract more logic in the future.

Screenshots

image

Testing

tested locally!

Changelog

no

Microsoft Reviewers:Open in CodeFlow

@TatianaKaposTatianaKapos requested a review froma team as acode ownerSeptember 5, 2023 23:28
@microsoft-github-policy-servicemicrosoft-github-policy-servicebot added the Area: FabricSupport Facebook Fabric labelSep 5, 2023

facebook::react::Size m_contentSize;
winrt::Microsoft::ReactNative::Composition::IVisual m_visual{nullptr};
winrt::Microsoft::ReactNative::Composition::ISpriteVisual m_visual{nullptr};
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@acoates-ms Every other component m_visual was a ISpriteVisual, so changed ScrollView's to match and it seemed to not affect anything on rnTester. Let me know if there was a reason for having this as a IVisual though and I can change it back!

voidupdateBorderProps(
const facebook::react::ViewProps &oldViewProps,
const facebook::react::ViewProps &newViewProps)noexcept;
voidupdateStyleProps(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe this should be called updateShadowProps, since that what it seems to handle. -- There are a lot of style props.

jonthysell and TatianaKapos reacted with thumbs up emoji
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree, best to keep them in groupings so we have view components can be more granular about opting-in.

voidupdateBorderProps(
const facebook::react::ViewProps &oldViewProps,
const facebook::react::ViewProps &newViewProps)noexcept;
voidupdateStyleProps(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree, best to keep them in groupings so we have view components can be more granular about opting-in.

Co-authored-by: Jon Thysell <thysell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@acoates-msacoates-msacoates-ms left review comments

@jonthyselljonthyselljonthysell approved these changes

Assignees

No one assigned

Labels

Area: FabricSupport Facebook FabricNew ArchitectureBroad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric

Projects

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Fabric] Finish implementing ShadowProps for other components

3 participants

@TatianaKapos@jonthysell@acoates-ms
[8]ページ先頭
©2009-2025 Movatter.jp