- Notifications
You must be signed in to change notification settings - Fork1.2k
Add cursorColor support to TextInput#11502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
jonthysell approved these changesApr 20, 2023
233 tasks
Contributor
jonthysell commentedApr 20, 2023
@acoates-ms, if they need it for paper, I assume we'll need it for Fabric too? |
Contributor
acoates-ms commentedApr 20, 2023
Yeah, this PR at least adds the property to the props object so its ready to implement. We should add it to the list of props to implement on fabric. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
I've added the support for the
cursorColorproperty to the macOS repo already. This PR will help to keep parity between platformsmicrosoft/react-native-macos#1787Type of Change
Why
The
cusrorColorproperty is already available on macOS aftermicrosoft/react-native-macos#1787 and documented in the docshttps://reactnative.dev/docs/textinput#cursorcolor-android. However, there is currently no way to update the cursor/caret color on Windows.What
HideCaretIfNeededlogic to support the custom color of a caret. This function is already, in a sense, changing the color of a caret; however, it always sets it to be transparent. Now, we allow custom colors as wellScreenshots
React.Native.Playground.Win32.2023-04-16.19-10-09.mp4
Microsoft Reviewers:Open in CodeFlow