- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: throw FileNotFoundError for nonexistant files#3014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
dgozman approved these changesDec 8, 2025
Contributor
dgozman commentedDec 8, 2025
I don't quite understand why server-side code would lead to a timeout, but client-side check sounds good to me. |
MemberAuthor
Skn0tt commentedDec 8, 2025
The server-side check is in a retry condition, and we don't abort the retry when it occurs. Client-side is better anyways because it throws the platform-standard exceptions. |
d3f5438 intomicrosoft:main 38 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Skn0tt added a commit that referenced this pull requestDec 9, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closesmicrosoft/playwright#38450. We were only checking file existence on the server (https://github.com/microsoft/playwright/blob/f9e039408b70ab27b5107de3863343236d8835ae/packages/playwright-core/src/server/dom.ts#L655-L657), but didn't surface the error, so it showed up as a timeout. In Node.js, we check file existence on the client (https://github.com/microsoft/playwright/blob/f9e039408b70ab27b5107de3863343236d8835ae/packages/playwright-core/src/client/elementHandle.ts#L263), mirroring this behaviour to Python.