Commit9ab4db2

authored

chore: fix type warnings on windows (#2840)

1 parent85a57cd commit9ab4db2Copy full SHA for 9ab4db2

File tree

+13

-1

lines changed

+13

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ def _user_data_dir(self, userDataDir: Optional[Union[str, Path]]) -> str:`
`171`	`171`	`# Can be dropped once we drop Python 3.9 support (10/2025):`
`172`	`172`	`# https://github.com/python/cpython/issues/82852`
`173`	`173`	`ifsys.platform=="win32"andsys.version_info[:2]< (3,10):`
`174`		`-returnpathlib.Path.cwd()/userDataDir`
	`174`	`+returnstr(pathlib.Path.cwd()/userDataDir)`
`175`	`175`	`returnstr(Path(userDataDir).resolve())`
`176`	`176`	`returnstr(Path(userDataDir))`
`177`	`177`

Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,10 @@`
`27`	`27`	`def_test_signals_async(`
`28`	`28`	`browser_name:str,launch_arguments:Dict,wait_queue:"multiprocessing.Queue[str]"`
`29`	`29`	`)->None:`
	`30`	`+# On Windows, hint to mypy and pyright that they shouldn't check this function`
	`31`	`+ifsys.platform=="win32":`
	`32`	`+return`
	`33`	`+`
`30`	`34`	`os.setpgrp()`
`31`	`35`	`sigint_received=False`
`32`	`36`
`@@ -67,6 +71,10 @@ async def main() -> None:`
`67`	`71`	`def_test_signals_sync(`
`68`	`72`	`browser_name:str,launch_arguments:Dict,wait_queue:"multiprocessing.Queue[str]"`
`69`	`73`	`)->None:`
	`74`	`+# On Windows, hint to mypy and pyright that they shouldn't check this function`
	`75`	`+ifsys.platform=="win32":`
	`76`	`+return`
	`77`	`+`
`70`	`78`	`os.setpgrp()`
`71`	`79`	`sigint_received=False`
`72`	`80`
`@@ -103,6 +111,10 @@ def my_sig_handler(signum: int, frame: Any) -> None:`
`103`	`111`	`def_create_signals_test(`
`104`	`112`	`target:Any,browser_name:str,launch_arguments:Dict`
`105`	`113`	`)->None:`
	`114`	`+# On Windows, hint to mypy and pyright that they shouldn't check this function`
	`115`	`+ifsys.platform=="win32":`
	`116`	`+return`
	`117`	`+`
`106`	`118`	`wait_queue:"multiprocessing.Queue[str]"=multiprocessing.Queue()`
`107`	`119`	`process=multiprocessing.Process(`
`108`	`120`	`target=target,args=[browser_name,launch_arguments,wait_queue]`

Comments

(0)