Commit731b539

authored

chore: implement Request.service_worker (#3013)

1 parent2d30755 commit731b539Copy full SHA for 731b539

File tree

+58

-3

lines changed

+58

-3

lines changed

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@`
`66`	`66`	`fromplaywright._impl._browser_contextimportBrowserContext`
`67`	`67`	`fromplaywright._impl._fetchimportAPIResponse`
`68`	`68`	`fromplaywright._impl._frameimportFrame`
`69`		`-fromplaywright._impl._pageimportPage`
	`69`	`+fromplaywright._impl._pageimportPage,Worker`
`70`	`70`
`71`	`71`
`72`	`72`	`classFallbackOverrideParameters(TypedDict,total=False):`
`@@ -184,6 +184,13 @@ def url(self) -> str:`
`184`	`184`	`defresource_type(self)->str:`
`185`	`185`	`returnself._initializer["resourceType"]`
`186`	`186`
	`187`	`+@property`
	`188`	`+defservice_worker(self)->Optional["Worker"]:`
	`189`	`+returncast(`
	`190`	`+Optional["Worker"],`
	`191`	`+from_nullable_channel(self._initializer.get("serviceWorker")),`
	`192`	`+ )`
	`193`	`+`
`187`	`194`	`@property`
`188`	`195`	`defmethod(self)->str:`
`189`	`196`	`returncast(str,self._fallback_overrides.methodorself._initializer["method"])`

Lines changed: 18 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -113,6 +113,24 @@ def resource_type(self) -> str:`
`113`	`113`	`"""`
`114`	`114`	`return mapping.from_maybe_impl(self._impl_obj.resource_type)`
`115`	`115`
	`116`	`+ @property`
	`117`	`+ def service_worker(self) -> typing.Optional["Worker"]:`
	`118`	`+ """Request.service_worker`
	`119`	`+`
	`120`	+ The Service `Worker` that is performing the request.
	`121`	`+`
	`122`	`+ Details`
	`123`	`+`
	`124`	+ This method is Chromium only. It's safe to call when using other browsers, but it will always be `null`.
	`125`	`+`
	`126`	+ Requests originated in a Service Worker do not have a `request.frame()` available.
	`127`	`+`
	`128`	`+ Returns`
	`129`	`+ -------`
	`130`	`+ Union[Worker, None]`
	`131`	`+ """`
	`132`	`+ return mapping.from_impl_nullable(self._impl_obj.service_worker)`
	`133`	`+`
`116`	`134`	`@property`
`117`	`135`	`def method(self) -> str:`
`118`	`136`	`"""Request.method`

Lines changed: 18 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -113,6 +113,24 @@ def resource_type(self) -> str:`
`113`	`113`	`"""`
`114`	`114`	`return mapping.from_maybe_impl(self._impl_obj.resource_type)`
`115`	`115`
	`116`	`+ @property`
	`117`	`+ def service_worker(self) -> typing.Optional["Worker"]:`
	`118`	`+ """Request.service_worker`
	`119`	`+`
	`120`	+ The Service `Worker` that is performing the request.
	`121`	`+`
	`122`	`+ Details`
	`123`	`+`
	`124`	+ This method is Chromium only. It's safe to call when using other browsers, but it will always be `null`.
	`125`	`+`
	`126`	+ Requests originated in a Service Worker do not have a `request.frame()` available.
	`127`	`+`
	`128`	`+ Returns`
	`129`	`+ -------`
	`130`	`+ Union[Worker, None]`
	`131`	`+ """`
	`132`	`+ return mapping.from_impl_nullable(self._impl_obj.service_worker)`
	`133`	`+`
`116`	`134`	`@property`
`117`	`135`	`def method(self) -> str:`
`118`	`136`	`"""Request.method`

Lines changed: 1 addition & 1 deletion

Lines changed: 13 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ def handle_request(route: Route) -> None:`
`92`	`92`	`assertresponse.json()== {"foo":"bar"}`
`93`	`93`
`94`	`94`
`95`		`-deftest_should_report_if_request_was_from_service_worker(`
	`95`	`+deftest_should_report_if_response_was_from_service_worker(`
`96`	`96`	`page:Page,server:Server`
`97`	`97`	`)->None:`
`98`	`98`	`response=page.goto(server.PREFIX+"/serviceworkers/fetch/sw.html")`
`@@ -102,3 +102,15 @@ def test_should_report_if_request_was_from_service_worker(`
`102`	`102`	`withpage.expect_response("**/example.txt")asresponse_info:`
`103`	`103`	`page.evaluate("() => fetch('/example.txt')")`
`104`	`104`	`assertresponse_info.value.from_service_worker`
	`105`	`+`
	`106`	`+`
	`107`	`+@pytest.mark.only_browser("chromium")`
	`108`	`+deftest_should_report_service_worker_request(page:Page,server:Server)->None:`
	`109`	`+withpage.context.expect_event("serviceworker")asworker_info:`
	`110`	`+page.goto(server.PREFIX+"/serviceworkers/fetch/sw.html")`
	`111`	`+page.evaluate("() => window.activationPromise")`
	`112`	`+withpage.context.expect_event(`
	`113`	`+"request",lambdar:r.service_workerisnotNone`
	`114`	`+ )asrequest_info:`
	`115`	`+page.evaluate("() => fetch('/example.txt')")`
	`116`	`+assertrequest_info.value.service_worker==worker_info.value`

Comments

(0)