Commit1be34f2

authored

fix: timeout option support with fetch api (#2947)

1 parent6e9ff7a commit1be34f2Copy full SHA for 1be34f2

File tree

+21

-2

lines changed

+21

-2

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -412,6 +412,7 @@ async def _inner_fetch(`
`412`	`412`	`self._timeout_settings.timeout,`
`413`	`413`	`{`
`414`	`414`	`"url":url,`
	`415`	`+"timeout":timeout,`
`415`	`416`	`"params":object_to_array(params)ifisinstance(params,dict)elseNone,`
`416`	`417`	`"encodedParams":paramsifisinstance(params,str)elseNone,`
`417`	`418`	`"method":method,`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,15 @@ async def test_should_support_global_timeout_option(`
`89`	`89`	`awaitrequest.get(server.EMPTY_PAGE)`
`90`	`90`
`91`	`91`
	`92`	`+asyncdeftest_should_support_timeout_option_in_get_method(`
	`93`	`+playwright:Playwright,server:Server`
	`94`	`+)->None:`
	`95`	`+request=awaitplaywright.request.new_context()`
	`96`	`+server.set_route("/empty.html",lambdareq:None)`
	`97`	`+withpytest.raises(Error,match="APIRequestContext.get: Timeout 123ms exceeded."):`
	`98`	`+awaitrequest.get(server.EMPTY_PAGE,timeout=123)`
	`99`	`+`
	`100`	`+`
`92`	`101`	`asyncdeftest_should_propagate_extra_http_headers_with_redirects(`
`93`	`102`	`playwright:Playwright,server:Server`
`94`	`103`	`)->None:`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ def _handler(request: TestServerRequest) -> None:`
`34`	`34`	`asyncdefhandle(route:Route)->None:`
`35`	`35`	`withpytest.raises(Error)aserror:`
`36`	`36`	`awaitroute.fetch(timeout=1000)`
`37`		`-assert"Timeout 1000ms exceeded"inerror.value.message`
	`37`	`+assert"Route.fetch:Timeout 1000ms exceeded."inerror.value.message`
`38`	`38`
`39`	`39`	`awaitpage.route("*/",lambdaroute:handle(route))`
`40`	`40`	`withpytest.raises(Error)aserror:`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -71,6 +71,15 @@ def test_should_support_global_timeout_option(`
`71`	`71`	`request.get(server.EMPTY_PAGE)`
`72`	`72`
`73`	`73`
	`74`	`+deftest_should_support_timeout_option_in_get_method(`
	`75`	`+playwright:Playwright,server:Server`
	`76`	`+)->None:`
	`77`	`+request=playwright.request.new_context()`
	`78`	`+server.set_route("/empty.html",lambdareq:None)`
	`79`	`+withpytest.raises(Error,match="APIRequestContext.get: Timeout 123ms exceeded."):`
	`80`	`+request.get(server.EMPTY_PAGE,timeout=123)`
	`81`	`+`
	`82`	`+`
`74`	`83`	`deftest_should_propagate_extra_http_headers_with_redirects(`
`75`	`84`	`playwright:Playwright,server:Server`
`76`	`85`	`)->None:`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ def _handle(request: TestServerRequest) -> None:`
`34`	`34`	`defhandle(route:Route)->None:`
`35`	`35`	`withpytest.raises(Error)aserror:`
`36`	`36`	`route.fetch(timeout=1000)`
`37`		`-assert"Request timed out after1000ms"inerror.value.message`
	`37`	`+assert"Route.fetch: Timeout1000ms exceeded."inerror.value.message`
`38`	`38`
`39`	`39`	`page.route("*/",lambdaroute:handle(route))`
`40`	`40`	`withpytest.raises(Error)aserror:`

Comments

(0)