- Notifications
You must be signed in to change notification settings - Fork10
FIX: Interactive on Windows#142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This pull request fixes interactive authentication handling on Windows by adjusting how theauth_type is set in theprocess_auth_parameters function. The change ensures that interactive authentication is properly configured before checking the platform, allowing Windows to handle AADInteractive natively.
- Moves the
auth_type = "interactive"assignment to occur before the Windows platform check - Sets
auth_type = Noneon Windows to allow native AADInteractive handling instead of skipping parameter addition
Comments suppressed due to low confidence (1)
4bf2a4e intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
ADO Work Item Reference
Summary
This pull request includes a small change to the
process_auth_parametersfunction inmssql_python/auth.py. The change adjusts how theauth_typeis handled for interactive authentication on Windows, ensuring compatibility with native handling of AADInteractive.