- Notifications
You must be signed in to change notification settings - Fork11
FIX: Adding row string#136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR enhances theRow class’s string output by introducing a user-facing__str__ method and refining the__repr__ for clearer debugging.
- Added
__str__to return a stringified tuple of row values - Updated
__repr__to use the built-inreprof the tuple for debugging
Comments suppressed due to low confidence (2)
mssql_python/row.py:69
- [nitpick] The
__repr__output now omits the class name and only shows a bare tuple, which can be ambiguous during debugging. Consider including theRowclass name in the output (e.g.,f"Row({repr(tuple(self._values))})") to make the object type explicit.
return repr(tuple(self._values))mssql_python/row.py:63
- There are no existing tests covering the new
__str__method (and the updated__repr__). Adding unit tests to verify their outputs will help prevent regressions and ensure correct formatting.
def __str__(self):There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lets add a testcase in test_cursor py file
6e11847 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
ADO Work Item Reference
Summary
This pull request modifies the
Rowclass inmssql_python/row.pyto improve its string representation methods. The changes include adding a__str__method for user-friendly output and updating the__repr__method to focus on debugging.Enhancements to string representation:
__str__method to provide a user-friendly string representation of theRowobject by returning the tuple of its values as a string.__repr__method to provide a more detailed representation for debugging purposes by using thereprfunction on the tuple of values instead of a formatted string.