- Notifications
You must be signed in to change notification settings - Fork11
FEAT: Smoke Testing pip installation on Blank Docker Images#132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR adds smoke testing for themssql-python package on minimal Docker images and provides a Dockerfile for a UBI9‐based Python 3.12 container.
- Introduces a new Azure Pipelines config (
pypi-package-smoketest.yml) that spins up UBI9, Ubuntu, and Debian containers, installs Python/pip, and runs a simplemain.pytest. - Adds a
Dockerfilefor UBI9 Python 3.12 that creates and activates a virtual environment.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/pypi-package-smoketest.yml | CI pipeline to smoke‐test PyPI package installation on three Linux distros |
| Dockerfile | UBI9‐based Python 3.12 image with a preconfigured virtual environment |
Comments suppressed due to low confidence (3)
eng/pipelines/pypi-package-smoketest.yml:43
- Ubuntu 22.04 and Debian 12 default apt repositories do not include Python 3.12. Attempting to install
python3.12will fail. Consider either using the system Python (e.g.python3), adding a PPA/debian backports, or aligningpython_versionwith the distro’s available version.
python$(python_version) \eng/pipelines/pypi-package-smoketest.yml:30
- [nitpick] The inline shell block is quite large and repeated across matrix entries. Consider extracting these steps into a shared script file (e.g.
scripts/smoketest.sh) to improve readability and reduce duplication.
- script: |Dockerfile:7
- [nitpick] Pinning the virtual environment path is fine, but you may want to ensure
python3always points to the expected minor version (3.12) by adding apython3.12symlink or using the explicit binary (python3.12).
RUN python3 -m venv $VENV_PATHsumitmsft approved these changesJul 16, 2025
jahnvi480 approved these changesJul 16, 2025
4b8949b intomain 16 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
ADO Work Item Reference
Summary
Testing driver on minimal docker images with just python installed.
This pull request introduces smoke testing the package from PyPI.
Pipeline Enhancements:
pypi-package-smoketest.yml, to perform smoke tests on PyPI packages across three Linux distributions: UBI9 (RHEL), Ubuntu, and Debian. This ensures compatibility and reliability of the package across different environments.