- Notifications
You must be signed in to change notification settings - Fork11
FIX: Robust resource cleanup of Connection/Cursor for graceful exit & add tests#128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
jahnvi480 previously approved these changesJul 16, 2025
Uh oh!
There was an error while loading.Please reload this page.
jahnvi480 approved these changesJul 16, 2025
gargsaumya approved these changesJul 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
4116996
intomain 16 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
ADO Work Item Reference
Summary
This pull request introduces enhancements to cursor and connection management in the
mssql_python
library, aiming to improve resource cleanup and debugging capabilities. Key changes include adding destructors for automatic cleanup, enhancing logging for better traceability, and introducing new tests to validate cursor behavior during garbage collection and connection closure.Resource Cleanup Enhancements:
__del__
method inmssql_python/connection.py
to automatically close connections during object destruction, with error logging for cleanup issues.__del__
method inmssql_python/cursor.py
to ensure cursors are closed when no longer needed, with error handling during destruction.Debugging Improvements:
mssql_python/connection.py
andmssql_python/cursor.py
with detailed print statements for tracking cursor states and operations (e.g., during connection closure, statement execution, and data fetching).[1][2][3][4]Testing Additions:
test_cursor_cleanup_without_close
to verify that cursors are properly cleaned up when the connection is not explicitly closed.test_no_segfault_on_gc
to ensure no segmentation faults occur during garbage collection of connections and cursors. This test runs in a subprocess to isolate potential crashes.