- Notifications
You must be signed in to change notification settings - Fork11
CHORE: Publish Symbols Pipeline#105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
Adds a new pipeline task to publish.pdb symbol files as build artifacts under the namemssql-python-symbols.
- Introduces a
PublishBuildArtifacts@1step conditioned on success or failure - Points
PathtoPublishat$(Build.ArtifactStagingDirectory)\all-pdbs - Uses
mssql-python-symbolsas the artifact name
Comments suppressed due to low confidence (2)
eng/pipelines/build-whl-pipeline.yml:165
- Use forward slashes for
PathtoPublishto ensure cross-platform compatibility (e.g.,$(Build.ArtifactStagingDirectory)/all-pdbs).
PathtoPublish: '$(Build.ArtifactStagingDirectory)\all-pdbs'eng/pipelines/build-whl-pipeline.yml:161
- [nitpick] Consider adding a preceding step to create or clean the
all-pdbsdirectory so that you don’t publish stale or missing artifacts.
# Publish the collected .pdb file(s) as build artifacts| SymbolsProduct: mssql-python | ||
| # Have kept the default version as the build ID, which is unique for each build | ||
| # This will be used to identify the symbols in the symbol server | ||
| SymbolsVersion: $(Build.BuildId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Need to change ID forSymbolsVersion - perhaps the driver release version?
| env: | ||
| SymbolServer: '$(SymbolServer)' | ||
| SymbolTokenUri: '$(SymbolTokenUri)' | ||
| requestName: '$(Build.DefinitionName)-$(Build.BuildId)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
kept this since requestName needs to be unique for each API call. Might need to change this?
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: David Engel <dengel1012@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
ADO Work Item Reference
Summary
This pull request includes a small addition to the build pipeline configuration in
eng/pipelines/build-whl-pipeline.yml. The change adds a new task to publish.pdbfiles as build artifacts under the namemssql-python-symbols.