Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update webpack plugin to support module workers#4742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hediet merged 2 commits intomicrosoft:mainfromRoccoC:webpack-plugin-esm
Apr 7, 2025

Conversation

@RoccoC
Copy link
Contributor

This is a proposed fix for#4741 .

This PR updates themonaco-editor-webpack-plugin'sgetWorkerUrl to add support for module workers. The function now checks ifimport.meta is defined, and if so, usesimport to load the worker script. Otherwise, it falls back to usingimportScripts for classic workers.

lbstr, icholy, anachronzy, bytesnow001, Champf, heartacker, and ubergerie reacted with thumbs up emoji
@RoccoC
Copy link
ContributorAuthor

@microsoft-github-policy-service agree

@ginna-baker
Copy link

Bump -- could really use this for my team

michaelhabibi, lbstr, 18568803179, and ubergerie reacted with heart emoji

@RoccoC
Copy link
ContributorAuthor

*gentle nudge*

Is there anything I can do to get eyes on this one? 🙏

@18568803179
Copy link

good,Hopefully it will merge soon

@bytesnow001
Copy link

@hediet

@ppgovekar
Copy link

We are using react-monaco-editor in Azure Portal, and it seem that on latest version we are seeing same issue:#4741.
Can someone take look at above change and help merge it? It will help all of Azure Portal teams using react-monaco-editor.
Thanks in advance!

@hediet
Copy link
Member

Thanks for the PR!

@hediethedietenabled auto-mergeApril 7, 2025 13:28
@vs-code-engineeringvs-code-engineeringbot added this to theApril 2025 milestoneApr 7, 2025
@hediethediet merged commit495d075 intomicrosoft:mainApr 7, 2025
3 checks passed
@eruship
Copy link

is aready release v7.1.1? i can't install this changed version.

komaedaXnagito reacted with thumbs up emoji

@jurgenwerk
Copy link

Thanks for this fix, it works well for us.

@komaedaXnagito
Copy link

When will version 7.1.1 be released?

@vs-code-engineeringvs-code-engineeringbot locked and limited conversation to collaboratorsMay 22, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@hediethediethediet approved these changes

@alexr00alexr00alexr00 approved these changes

+6 more reviewers

@icholyicholyicholy approved these changes

@ppgovekarppgovekarppgovekar approved these changes

@caghandcaghandcaghand approved these changes

@benjaminsherrybenjaminsherrybenjaminsherry approved these changes

@michaelhabibimichaelhabibimichaelhabibi approved these changes

@bytesnow001bytesnow001bytesnow001 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

April 2025

Development

Successfully merging this pull request may close these issues.

14 participants

@RoccoC@ginna-baker@18568803179@bytesnow001@ppgovekar@hediet@eruship@jurgenwerk@komaedaXnagito@icholy@caghand@alexr00@benjaminsherry@michaelhabibi
[8]ページ先頭
©2009-2025 Movatter.jp