This repository was archived by the owner on Jun 30, 2022. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork526
[C#][Bot-Solutions] Fix MultiProviderAuthDialog not being localized#3760
Merged
ryanisgrig merged 2 commits intomicrosoft:masterfromsouthworks:feature/southworks/fix-MultiProviderAuthDialog-localizationFeb 5, 2021
Merged
[C#][Bot-Solutions] Fix MultiProviderAuthDialog not being localized#3760
ryanisgrig merged 2 commits intomicrosoft:masterfromsouthworks:feature/southworks/fix-MultiProviderAuthDialog-localizationFeb 5, 2021
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Allow ResponseManager to create a response using a specific locale- Make MultiProviderAuthDialog create a new auth dialog by eachconfigured locale
- Static readonly fields should begin with upper-case letter
srinaath commentedFeb 3, 2021
@lauren-mills could you take a look at this PR to close the ticket. |
Contributor
lauren-mills left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Are there any changes needed in the VA template to support these changes?
lauren-mills approved these changesFeb 4, 2021
ContributorAuthor
VictorGrycuk commentedFeb 5, 2021
Hi@lauren-mills, there is no need to modify the templates 🙂. |
3 tasks
srinaath commentedFeb 5, 2021
@ryanlengel Could we get another review on this PR to get it merged |
ryanisgrig approved these changesFeb 5, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#3560
Purpose
What is the context of this pull request? Why is it being done?
MultiProviderAuthDialog login dialog only works with the fallback language. It should be able to localize it using the user's locale.
The dialog isadded in the constructor of MultiProviderAuthDialog, before the activity from the user is received, therefore the locale of the user is unknown at this moment.
This fix revolves around the idea of adding dialogs of known language beforehand, and then using the user locale to retrieve their specific locale's dialog.
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
CurrentUICulture.Tests
Is this covered by existing tests or new ones? If no, why not?
The MultiProviderAuthDialog localization working using a skill connected to a virtual assistant
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
Checklist
General