- Notifications
You must be signed in to change notification settings - Fork526
Replace ’ to ' in .qna and .lu files and remove trailing spaces#3724
Replace ’ to ' in .qna and .lu files and remove trailing spaces#3724
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dawwa commentedNov 25, 2020
@Batta32, there is invalid white space as well, e.g., the highlighted piece at LINE#1344 is regular whitespace, not sure what is at the end of LINE#1343, please note it's just an example, need a bulk fix for all other files. |
Batta32 commentedNov 25, 2020
Thanks@dawwa, we will check this and update the PR. |
Batta32 commentedNov 25, 2020
@dawwa - we already removed the trailing spaces for the |
dawwa commentedNov 27, 2020
@Batta32 , would you please check the invalid space character in between as well? it's not only about trailing space, there are white spaces that are not consistent, I suspect it's due to Full-width vs half-width, e.g., I would suggest to copy the original white space at the problematic spot as seen below and compare with the regular whitespace you typed in with your keyboard when in English IME, and then bulk replace to capture other spots beyond the trailing ones.
|
Batta32 commentedNov 27, 2020
Sure@dawwa! We are currently working on fixing those spaces, thanks for the feedback 😊! |
Batta32 commentedNov 27, 2020
@dawwa - we already removed those inconsistent spaces. Feel free to review it and add your feedback 😊. |
Uh oh!
There was an error while loading.Please reload this page.
Fix#3711
Purpose
What is the context of this pull request? Why is it being done?
There are inconsistent characters
’vs'causing encoding issues.Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
For C# and TypeScript Virtual Assistant Template / Sample, Skill Template / Sample:
’to'in.qnafiles’to'in.lufiles.qna,.lu,.lgfilesTests
Is this covered by existing tests or new ones? If no, why not?
We manually tested the deploy of the QnA models and the communication with the bots with these changes.
Successful deployment of a Virtual Assistant with these changes
Successful communication to the Virtual Assistant with these changes
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
-
Checklist
General