This repository was archived by the owner on Jun 30, 2022. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork526
[C#][VSIX] Fix template placeholder not correctly replaced in Skill yml file#3679
Merged
peterinnesmsft merged 2 commits intomicrosoft:masterfromsouthworks:feature/southworks/fix-template-placeholder-not-replacedOct 19, 2020
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
peterinnesmsft approved these changesOct 16, 2020
ryanisgrig approved these changesOct 19, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#3673
Purpose
What is the context of this pull request? Why is it being done?
The
$safeprojectname$variable is not replaced correctly in the[SkillSample].yml file of the Pipeline Folder when a Skill project is created using the VSIX.Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
We made a change in the file
SkillProjectTemplate.vstemplate. In the sectionFolder Name Pipeline, configured the parameterReplaceParametersin true.Tests
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
Checklist
General