This repository was archived by the owner on Jun 30, 2022. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork526
[Virtual Assistant][Skill] Wrap with quotes the zip in the publish scripts#3594
Merged
peterinnesmsft merged 3 commits intomicrosoft:masterfromsouthworks:feature/southworks/fix-whitespaces-path-deployOct 16, 2020
Merged
[Virtual Assistant][Skill] Wrap with quotes the zip in the publish scripts#3594
peterinnesmsft merged 3 commits intomicrosoft:masterfromsouthworks:feature/southworks/fix-whitespaces-path-deployOct 16, 2020
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
lzc850612 approved these changesAug 13, 2020
peterinnesmsft approved these changesAug 13, 2020
1fdf40c toef95a97Comparepeterinnesmsft approved these changesOct 16, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#3581
Purpose
What is the context of this pull request? Why is it being done?
All assistant and skill bots would fail to publish during the deployment process, when done so from a folder containing white spaces in its path.
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
We wrapped in quotes the path to the zip at the az CLI deployment line inside the
publish.ps1of the following components:Tests
Is this covered by existing tests or new ones? If no, why not?
All tests remained passing like they did before the changes.
All bots were also tested to deploy, and generated from corresponding yeoman templates/VSIX extension, properly fixed.
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
-
Checklist
General