Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix Maven task rebuild when using jacoco for code coverage#21472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
v-gayatrij merged 11 commits intomasterfromusers/v-gayjaiswal/maven-run-fix
Nov 28, 2025

Conversation

@v-gayatrij
Copy link
Contributor

@v-gayatrijv-gayatrij commentedNov 20, 2025
edited
Loading

Context

Describe the context or motivation for this PR. Include links to any related Azure DevOps Work Items or GitHub issues.
📌 Associated WI:AB#2327840


Task Name

MavenV4


Description

Remove second maven run(during code coverage publishing step) to avoid running maven lifecycle phases twice.
The second adds verify phase when JaCoCo is selected as the code coverage -

This is because JaCoCo plugin binds its check goal to the Maven verify phase, which ensures that all tests have run and their coverage data is available -#6458 (comment).

This PR combines below 2 maven runs adding verify phase to the first run:

run to execute maven goals:

returnmvnRun.exec(util.getExecOptions());

maven run before publishing code coverage:

mvnReport.exec().then(function(code){


Risk Assessment (Low / Medium / High)

Low. Changes covered under feature flag


Change Behind Feature Flag (Yes / No)

Yes


Tech Design / Approach

  • Design has been written and reviewed.
  • Any architectural decisions, trade-offs, and alternatives are captured.

Documentation Changes Required (Yes/No)

Indicate whether related documentation needs to be updated.

  • User guides, API specs, system diagrams, or runbooks are updated.

Unit Tests Added or Updated (Yes / No)

Indicate whether unit tests were added or modified to reflect these changes.


Additional Testing Performed

canary test pipeline runs:

FF enabled -Pipelines - Run 20251125.8
FF disabled -Pipelines - Run 20251125.7


Logging Added/Updated (Yes/No)

  • Appropriate log statements are added with meaningful messages.
  • Logging does not expose sensitive data.
  • Log levels are used correctly (e.g., info, warn, error).

Telemetry Added/Updated (Yes/No)

  • Custom telemetry (e.g., counters, timers, error tracking) is added as needed.
  • Events are tagged with proper metadata for filtering and analysis.
  • Telemetry is validated in staging or test environments.

Rollback Scenario and Process (Yes/No)

  • Rollback plan is documented.

Dependency Impact Assessed and Regression Tested (Yes/No)

  • All impacted internal modules, APIs, services, and third-party libraries are analyzed.
  • Results are reviewed and confirmed to not break existing functionality.

Checklist

  • Related issue linked (if applicable)
  • Task version was bumped — seeversioning guide
  • Verified the task behaves as expected

@v-gayatrij
Copy link
ContributorAuthor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@v-gayatrij
Copy link
ContributorAuthor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@v-gayatrij
Copy link
ContributorAuthor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@v-gayatrijv-gayatrij marked this pull request as ready for reviewNovember 25, 2025 09:12
@v-gayatrij
Copy link
ContributorAuthor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@v-gayatrij
Copy link
ContributorAuthor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@v-gayatrijv-gayatrij merged commit458a2d5 intomasterNov 28, 2025
14 checks passed
@v-gayatrijv-gayatrij deleted the users/v-gayjaiswal/maven-run-fix branchNovember 28, 2025 06:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tarunramsinghanitarunramsinghanitarunramsinghani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@v-gayatrij@tarunramsinghani

[8]ページ先頭

©2009-2025 Movatter.jp